Add ability to ignore WorkspaceSharing audit results #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amstilp
commented
Jan 9, 2025
•
amstilp
commented
- Add a model and supporting views to track IgnoredWorkspaceSharing audit results
- Check IgnoredWorkspaceSharing when running WorkspaceSharingAudits
Add an abtract model that stores standard information for ignored audit results (e.g., who ignored it and a note). Use this abstract model to define the existing IgnoredManagedGroupMembership model and the new IgnoredWorkspaceGroupSharing model.
Add more namespaces, eg the by_workspace namespace.
Also add the get_absolute_url method for the model class.
Include the FilterView directly instead of adding it in a later commit; so also add a table and a filter class definition.
These subclasses track more infomration about a given "Not In App" audit result.
Update both the main audit class as well as the view. Add a link to the create view for an IgnoredWorkspaceSharing record in the not_in_app table.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 99.76% 99.77% +0.01%
==========================================
Files 166 172 +6
Lines 26181 27630 +1449
==========================================
+ Hits 26120 27569 +1449
Misses 61 61 ☔ View full report in Codecov by Sentry. |
Some of the tests assumed a specific ordering for IgnoredWorkspaceSharing records, plus there was a separate test to sepcific check ordering. Update the other tests to not rely on a specific ordering, such that the ordering is only tested in the specific test for it.
This mirrors how we defined a class for IgnoredWorkspaceSharing results; this way, we can store the current role that the email has in the group, and report it.
Some of the tests added a get_absolute_url method to the user. Delete the attribute so that other tests work as exepcted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.