Edit ssr #102
Merged
Edit ssr #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ssr: Updated web components Updated map interfaces Update web components Updated map interface page Updated dark mode provider Updated map page styles Paleo map interface works, but is incomplete Slightly updated paleo map interface Consolidated files Continue adding elements to paleo page Slightly more complete independent map page Moved paleogeography objects to paleo page No-op standalone map page Some updates to paleogeography
* style-fixes: Remove unused imports Renamed files to match code style Format codebase with prettier
* map-updates: (24 commits) Add react-router for keeping focus on table Fix css styles for table scrolling db_id -> _pkid Make edit panel properly resizable Use a more standard button Make null checks slightly less confusing Remove unused imports Renamed files to match code style Format codebase with prettier Things work mostly as they used to Updated web components Updated map interfaces Update web components Updated map interface page Updated dark mode provider Updated map page styles Paleo map interface works, but is incomplete Slightly updated paleo map interface Consolidated files Continue adding elements to paleo page ...
* main: Updated web components
* data-sheet-test: tried to add new dependencies Improved data sheet dependencies Created a basic testing page for data sheet updates Sync node versions Delete some files unused in the modern version
* origin/edit-ssr: Sort by _pkid on default and fix group bug Color id the columns used for final update Add in ability to group columns
* main: Updated data sheet test page Updated data sheet colors components Enable save/reset functionality for data sheet Added rudimentary fill-down functionality Added selection clearing Derive focused cell from selection Added a bit more description Basic testing data sheet
{{tag}}-{{timestamp}}
{{branch}}-{{timestamp}}
davenquinn
reviewed
Dec 18, 2023
There was a problem hiding this comment.
Overall, this seems pretty good and mostly ready to merge. A few issues remain, though:
- Remove unused added dependencies
- Login flow for secure API requests seems overly complex. Why not just use cookies as with the frontend pages? As it stands, it seems like you are running a login request for each API request, which seems like overkill
There also seem to be some small discrepancies with web components, map navbar, etc. with respect to main. If you haven't already, you should merge main into this branch to ensure that these sync easily.
Closed
davenquinn
reviewed
Dec 18, 2023
This was referenced Dec 18, 2023
Closed
Closed
Open
|
@davenquinn I am ready to merge, want to sign off? Ignore the broken actions below, we ran out of space on Harbor so I bumped us up. We can talk retention tomorrow. |
davenquinn
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.