Runtime environment #207
Merged
Runtime environment #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to avoid re-bundling the app to integrate environment variables in production.
We take all
VITE_-prefixed environment variables provided on the server and package them in a dictionary that is provided as bothprocess.env(server-side) andwindow.env(client-side).These variables can then be accessed using a
getRuntimeConfigfunction in either environment. Right now, that falls back to existing pre-bundled environment variables if they aren't provided at runtime, but we may want to change this behavior for clarity in the future.This approach requires some amount of discipline to not use environment variables directly in client-side code, but allows us to remove all bundling of the app in production, saving quite a bit of time on app startup.