Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Importing of CSV Files To Plan #83

Draft
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

AdrianSantoPasqualini
Copy link
Collaborator

@AdrianSantoPasqualini AdrianSantoPasqualini commented Feb 23, 2021

UPDATE: This feature was replaced by the Auth system. I am keeping this PR around in case we still want to add something like this later.

Adds a new tab which gives a brief explanation to the user and lets them upload csv files.

The courses will be read from the csv and added to the plan.

@kevinfwl
Copy link
Member

kevinfwl commented Mar 2, 2021

Do we need to assume that the user doesn't change majors? I am getting this by:

  1. Selecting actsci
  2. Downloading actsci csv
  3. Selecting general science
  4. Apply actsci csv

image

@kevinfwl
Copy link
Member

kevinfwl commented Mar 2, 2021

Also am getting these duplicates, is this expected as well?
image

@AdrianSantoPasqualini
Copy link
Collaborator Author

Do we need to assume that the user doesn't change majors? I am getting this by:

  1. Selecting actsci
  2. Downloading actsci csv
  3. Selecting general science
  4. Apply actsci csv

image

Are the course cards that got added working correctly?

@AdrianSantoPasqualini
Copy link
Collaborator Author

Also am getting these duplicates, is this expected as well?
image

Duplicates are expected, all the import is doing is taking the courses from the csv and adding them to the plan, The csv doesnt have any information about what underlying choices resulted in those courses, so I cant remove them from the requirement bar.

Perhaps I should give more detail as to how the import works in the tab description

@kevinfwl
Copy link
Member

kevinfwl commented Mar 2, 2021

Yeah I think everything is working correctly functionality-wise other than those two; adding an explanation to the import page should be good.

@AdrianSantoPasqualini AdrianSantoPasqualini marked this pull request as draft March 4, 2021 04:12
@CalderLund CalderLund changed the base branch from master to staging March 12, 2021 14:37
@haowei99
Copy link
Contributor

haowei99 commented Sep 5, 2021

What are we doing with this?

@haowei99
Copy link
Contributor

Tested, CSS looks really clean!

I noticed the background color of the sign out button isn't the same as the add courses (it is actually #f5f5f5, not white). I have already pushed a commit to address this.

Good to merge to prod. @b47huang Please take a look at it as the last pair of eyes.

@haowei99 haowei99 marked this pull request as ready for review October 22, 2021 05:20
@AdrianSantoPasqualini AdrianSantoPasqualini marked this pull request as draft November 7, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants