Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 14 for the forecasting plugin #100

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Step 14 for the forecasting plugin #100

merged 7 commits into from
Jun 20, 2024

Conversation

pritamd47
Copy link
Member

Added step 14 for the forecasting plugin. The forecast function now also converts the forecasted results to the final format.

SarathUW
SarathUW approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@SarathUW SarathUW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

SanchitMinocha
SanchitMinocha requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@SanchitMinocha SanchitMinocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked into the different forecasting_scenario functions in detail, but otherwise looks good. Left a few minor comments that needs fixing. Also, I will recommend updating the forecasting documentation as well regarding the different scenarios.

SanchitMinocha
SanchitMinocha approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@SanchitMinocha SanchitMinocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for updating it.

@SanchitMinocha SanchitMinocha merged commit 51da4fe into main Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarathUW SarathUW SarathUW approved these changes

@SanchitMinocha SanchitMinocha SanchitMinocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pritamd47 @SanchitMinocha @SarathUW