ResORR plugin and minor fix for forecasting #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/rat/plugins/forecasting.py
Outdated
src/rat/plugins/resorr/runResorr.py
Outdated
| from rat.plugins.resorr.data_prep import generate_network | ||
| from resorr.data_prep import generate_forcings_from_rat, generate_network | ||
| from resorr.network import ReservoirNetwork | ||
| from tqdm.notebook import tqdm |
There was a problem hiding this comment.
removed. Thanks for checking the code.
SanchitMinocha
requested changes
Feb 19, 2024
SanchitMinocha
approved these changes
Feb 20, 2024
|
Forgot to mention it earlier - @pritamd47 or @SarathUW |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1
Fixed runtime issues with forecasting plugin
- rat fails if PLUGINS section is not present in config.
- removed unused import cfgrib statement
Commit 2
Adding the ResORR plugin to RAT