Fix token capture from the hidden iframe on refresh #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…token from hidden iframe work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tricky one to explain.
It seems that the app inside the hidden iframe re-renders several times before the outer app tries to grab the token from it. This means that
isRefreshingInIframeis no longer true in theTokenManagerin the hidden iframe, so the<div id="token">is not rendered. This means that the outer app can't find the token when it looks for it, and it gets stuck in an infinite loop of "checked for new token, not found yet".This PR makes
isRefreshingInIframean instance variable in theTokenManager, so it persists through the refreshes, so the token div is still there inside the iframe when the outer app comes looking for it.