-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libreoffice] update installation instructions for udocker and CODE #1196
Conversation
they changed upstream fixes Uberspace#1178
fixes Uberspace#1192 container changed upstream, e.g. admin console URL, and docker container libreoffice/online seems to be abandoned for the time being
The init script of the collabora CODE docker only uses the documented 'domain' environment variable if the 'storage.wopi.host[0]' is set to 'localhost' in the config file '/etc/coolwsd/coolwsd.xml'. This means, if we had set 'domain=foo' on one start, we cannot change it later. Therefore, we now set the wopi host by setting the commandline option --o:storage.wopi.host[0] via 'extra_params'. This always takes precedence over the value in the config file.
@therealsimwoe would you like to review the change, especially the udocker fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jorsn ! Looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please excuse the delay - my query is already from March 15 and I simply neglected to submit it as well.
[isabell@stardust ~]$ tar zxvf udocker-1.3.1.tar.gz | ||
[isabell@stardust ~]$ | ||
|
||
Then, create a wrapper script ``$HOME/bin/udocker`` with the following content: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it works as described with the wrapper, I wonder why it is necessary. A symlink does it also, is less error-prone and in addition still faster deposited. Or what do you think?
Please excuse the delay - my query is already from March 15 and I simply neglected to submit it as well.
Excused ;) Thanks for the query!
Although it works as described with the wrapper, I wonder why it is necessary. A symlink does it also, is less error-prone and in addition still faster deposited. Or what do you think?
A symlink does it not, because the udocker python script uses $0 to set the python module search path (try it out, it breaks).
In the udocker installation manual, they simply add the udocker dir to $PATH, but I don't like that, since then the $PATH dirs are cluttered with files that shall not be executed, and one has to modify $PATH permanently.
|
Thanks for the fix, I just merged it. A quick heads up: We're thinking about removing the guide because it's very complex and we're having many users with questions about the guide and udocker in general. Can you get in touch with us via hallo@uberspace.de please? Me might have another little something for you 👕 because this MR took so long... |
Thanks for the fix, I just merged it.
Thanks!
A quick heads up: We're thinking about removing the guide because it's very complex and we're having many users with questions about the guide and udocker in general.
Of course I don't know about those questions, as I only had two (?) support requests so far, but if this can be alleviated by improving the guide, please let me know, e.g. what you/people find unclear about the guide.
EDIT:
Compared to some other guides, I don't find this one so outstandingly complex (it might still be unclear), but certainly the system udocker + libreoffice + nextcloud is, and thus it is quite sensitive to small deviations from the guide.
Also, the docker container is apparently designed to be configured once, which caused, e.g., the bug fixed in 0ce3cf0.
As this guide was long requested (#160), it might be beneficial to keep it somehow, even if removed from the Uberlab (see #1249).
|
@nichtmax Please do not remove this guide! I think the topic is complex yes - but also me as not that experienced uberspace user could manage to get it up and running by myself (and see I even tried to improve the guide with: #1178 once I noticed something does not work correctly with the current udocker version). So my request would be definitely to leave this guide up and running ... ! |
fixes #1178
fixes #1192
allows changing the wopi host setting after the first run
collabora/code
container changed upstream, e.g. admin console URLlibreoffice/online
seems to be abandoned for the time beingcollabora/code
only allows to change thedomain
setting one time. Later changes take no effect. I found a workaround.