Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitwarden_rs] update guide to fix cargo build issue #694

Closed
wants to merge 1 commit into from

Conversation

pxlfrk
Copy link
Contributor

@pxlfrk pxlfrk commented Jun 29, 2020

Hi!

in #609 @luto told me that Uberspace will support Rust in the Version 7.6.2, which is indeed correct - but only the stable release channel. Bitwarden_rs depends on the nightly release channel, so as described right now in the guide cargo build -j 1 --release --features sqlite will fail.

Compiling pear_codegen v0.1.4
error: failed to run custom build command for pear_codegen v0.1.4

Caused by:
process didn't exit successfully: /home/passres/bitwarden_rs/target/release/b uild/pear_codegen-eb17718987529976/build-script-build (exit code: 101)
--- stderr
Error: Pear requires a 'dev' or 'nightly' version of rustc.

Therefore I re-added the rust-installation section to the guide to fix this issue.

Another solution would be to include also the nightly and/or dev release channels to the default uberspace installation.

Looking forward for your Feedback to solve this issue.

+ added rust nightly installation (again) since the cargo build requires the nightly release channel and uberspace at this moment only provides the stable channel
@luto
Copy link
Member

luto commented Jun 29, 2020

sigh 😅 do you have any recommendations on which of the nightly releases to provide? is it fine to provide the latest nightly that actually builds the relevant tools as a "nightly" channel?

@pxlfrk
Copy link
Contributor Author

pxlfrk commented Jun 29, 2020

As far as i can tell i would recomment using rustup for this guide as it's mentioned in the official setup documentation; the latest nightly-release-channel should also work. At least i think so..

@pxlfrk
Copy link
Contributor Author

pxlfrk commented Jul 11, 2020

cc #708 for further information.

@jonmz
Copy link
Contributor

jonmz commented Jul 11, 2020

cc #708 for further information.

Oh, thanks, I just scrolled through the open issues regarding bitwarden, not through open PRs. Tbh I am not really keen on providing nightly builds unless absolutely necessary, and for that I would like to get at least some basic understanding why a nightly build (even one from 2018) is needed for Pear but a stable build from 2020 would not do it... we are strictly sticking with stable versions on other programming languages as well. If possible I would prefer Rust being no exception, but will keep this PR open for now.

@pxlfrk
Copy link
Contributor Author

pxlfrk commented Jul 11, 2020

I absolutely agree with you, in theory the stable release should work fine. I'd prefer waiting for the result of the issue you referenced.

@luto
Copy link
Member

luto commented Jul 20, 2020

postponed until we've got some replies in the issue.

@luto
Copy link
Member

luto commented Jul 21, 2020

This should be fixed in a future bitwarden/pear release: SergioBenitez/Pear#23 (comment). Thanks for the PR, though!

@luto luto closed this Jul 21, 2020
@pxlfrk pxlfrk deleted the bitwarden_rs_guide_fix branch September 18, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants