Changed fiducial len #129
Merged
Changed fiducial len #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohbotics
approved these changes
Aug 11, 2020
|
loki_robot is no longer being used or developed, so I wouldn't bother updating that. If there is somewhere else you found an inconsistency let me know. Thanks for making this change, you are good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should solve issue #125.
I did a quick research in other repositories and found many more similar cases where the default fiducial len is not set to 14 cm. For example https://github.com/UbiquityRobotics/loki_robot/blob/master/loki_demos/launch/fiducial_follow.launch