Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test, bench: remove globals vCoins and testWallet from test and bench
adapted from a5595b1 and 5e54aa9 in bitcoin#23288. changes to coinselector_tests must be reverted before backports related to it are done as these changes are primarily motivated by bitcoin#21866 taking away the global chainstate, which breaks coinselector_tests and these changes skips over a lot of backporting, making them incompatible with backporting efforts (or even the commits its adapted from). the existing behaviour was that it creates its own testNode but doesn't populate it with a ChainstateManager (or much at all) while the rest of the client uses WalletTestingSetup's values. for the longest time this was fine because addCoins > listMNCollaterials > ChainActive() meant that it was using the fallback, but when chainstate globals are removed, WalletTestingSetup's values can't serve as a fallback anymore as it'd now be looking for NodeContext::chainman::m_chain, and chainman wasn't setup with testNode and the tests crash.
- Loading branch information