Simply order by offset also when not doing brute force to fix #1208 #1210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression was "introduced" in
5a6b3970but removing the code now makes theIssue874test fail. As a result it appears this commit just surfaced another issue (cc @ricflams)@EliotJones do you remember why you introduced custom order logic when not doing brute force? I'm now using the same logic for both paths and it looks like it works.This was originally part of commit
0afe021a