Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more emoji icon packs for opinionated users #6

Closed
MyriaCore opened this issue Jun 27, 2020 · 4 comments · Fixed by #8
Closed

Provide more emoji icon packs for opinionated users #6

MyriaCore opened this issue Jun 27, 2020 · 4 comments · Fixed by #8

Comments

@MyriaCore
Copy link
Contributor

I think a big step would be to offer twemoji and noto-emoji, as those are the most common emoji packs used.

We could have a settings menu setting to manage which style of emoji the user prefers, and keep the default on 'apple' (the style of emojis being used now).

@MyriaCore
Copy link
Contributor Author

MyriaCore commented Jun 27, 2020

I'm hoping to deliver this feature via my fork. I'll submit a PR when it's close to being finished. @gornostal do you want me to submit a WIP PR, or would you prefer if I only submit a PR when the code is ready for review?

@gornostal
Copy link
Member

gornostal commented Jun 28, 2020 via email

@MyriaCore
Copy link
Contributor Author

Got it, I might be able to PR by the end of the day! I just got this thing working with twemoji. There seem to be some caveats to blobmoji and noto-emoji, but twemoji support seems the strongest by far.

demo

@MyriaCore
Copy link
Contributor Author

@gornostal PR is live at #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants