-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for optimization sequence in scanning toolchain #155
Conversation
…ion if checker fails
With Hotfix #156 load all modules completes without errors. |
That's definitely an improvement. |
…-iqo-modules into 1d_scanner_optimize
…e unnecessary code
As discussed in the software meeting, all debug and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Description
Fixes that the optimizer could not perform optimization sequences other than the default [2, 1], e.g. ["xy","z"]. By changing the checker function of the ConfigOption
ScannerGui.optimizer_plot_dimensions
to a constructor that correctly checks the constraints. Furthermore, the selection of available sequences is now handled byscanning_optimize_logic
, the GUI only access it.A signal is added to lay the ground for future implementation of adjusting the optimizer sequence during runtime.
Motivation and Context
The
ScannerGui.optimizer_plot_dimensions
ConfigOption is there to adjust the optimization sequence to an arbitrary combination of 2D and 1D optimizations within the constraints of the hardware (i.e. number of axes). It should be possible with e.g. 3 Axes to perform the default 2D and 1D optimization, but also any subset of these. E.g. only a 1D or multiple 1D optimizations. Due to a bug in the checker method of the ConfigOption it was not possible to select only 1D optimizations. Furthermore, it was not possible to changeScanningOptimizeLogic._scan_sequence
once it was stored as a StatusVar and the default fallback for the StatusVar was hardcoded to a sequence of [2,1].How Has This Been Tested?
Default config file
Types of changes
Checklist:
/docs/changelog.md
.(syntax, indentation, mutable default values, etc.).