Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix on thread error for laser toolchain #172

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

takuya-ulm
Copy link
Contributor

Bug fix on the laser gui, reported in the issue 153:
#153

Description

Missing disconnect() functions were added.

Motivation and Context

How Has This Been Tested?

Followed the procedure in #153.

  1. activate gui
  2. deactivate gui
  3. deactivate logic
  4. reactivate gui

Now the error related to the threading disappeared.

Screenshots (only if appropriate, delete if not):

Types of changes

  • Bug fix
  • New feature
  • Breaking change (Causes existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in /docs/changelog.md.
  • My change requires additional/updated documentation.
  • I have updated the documentation accordingly.
  • I have added/updated the config example for any module docstrings as necessary.
  • I have checked that the change does not contain obvious errors
    (syntax, indentation, mutable default values, etc.).
  • I have tested my changes using 'Load all modules' on the default dummy configuration.
  • All changed Jupyter notebooks have been stripped of their output cells.

Copy link
Contributor

@NicolasStaudenmaier NicolasStaudenmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the PR does not solve the issue as reported in #153. We're waiting for the overhaul of Qudi core which should solve the fundamental problem.
However, it is an obvious improvement of the code disconnecting the widgets on deactivation of the GUI. Thanks Takuya.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants