Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for issue in #170 #179

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Hotfix for issue in #170 #179

merged 6 commits into from
Jan 21, 2025

Conversation

TobiasSpohn
Copy link
Contributor

Description

Fixes the initialization error occuring when configuring scanner with less than 3 axes as described in #170 .

Motivation and Context

A bug caused in _set_default_scan_sequence to always raise the NotImplementedError in _allowed_sequences if the default _optimizer_sequence_dimensions were used with scanners that have less than 3 axes configured.

How Has This Been Tested?

Dummy session having only x and y axis configured.

Types of changes

  • Bug fix
  • New feature
  • Breaking change (Causes existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in /docs/changelog.md.
  • My change requires additional/updated documentation.
  • I have updated the documentation accordingly.
  • I have added/updated the config example for any module docstrings as necessary.
  • I have checked that the change does not contain obvious errors
    (syntax, indentation, mutable default values, etc.).
  • I have tested my changes using 'Load all modules' on the default dummy configuration.
  • All changed Jupyter notebooks have been stripped of their output cells.

@timoML
Copy link
Contributor

timoML commented Jan 11, 2025

Looks good, thank you.
Can you quickly check that with StatusVar from a 3 axis scanner:

  • scanning_probe_logic and scanning_gui crash on load
  • the commits I added should solve this

@timoML
Copy link
Contributor

timoML commented Jan 14, 2025

In future, we should think about a more elegant solution of check_scan_settings in scanning_probe_logic and scanning_optimize logic. For now, this hotfix is a big improvement already.

@timoML timoML self-requested a review January 14, 2025 12:21
Copy link
Contributor

@timoML timoML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

@TobiasSpohn TobiasSpohn merged commit b675391 into main Jan 21, 2025
@TobiasSpohn TobiasSpohn deleted the scanner_optimization_hotfix branch January 21, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants