add a new hardware file #31
Conversation
add a hardware file to control the Keysight power supply.
| # -*- coding: utf-8 -*- | ||
|
|
||
| """ | ||
| Control the Radiant Dyes flip mirror driver through the serial interface. |
| # Excelitas APD: 5V,1.3A | ||
| self._instrument.write('INST CH1') | ||
| self._instrument.write('OUTP 0') | ||
| self._instrument.write('VOLT 5') |
There was a problem hiding this comment.
Maximum voltages should be ConfigOptions, not hardcoded.
There was a problem hiding this comment.
Now the voltages and currents are taken from ConfigOption
|
|
||
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self.lock = RecursiveMutex() |
There was a problem hiding this comment.
I think the lock is not needed in this module.
There was a problem hiding this comment.
These lines are used in all switch hardwares. I think we may keep it for now for unification
|
@liuyanulm Is the power supply API compatible with the existing hw file for the E3631A? In this case, we might think of unifying the files and fullfill both the ProcessControlInterface and the SwitchInterface. |
|
Interesting idea. I also had a similar thought when I notice the |
1. corrected typo. 2. voltages and currents are taken from ConfigOption.
@timoML The Keysight power supplies are not controlled via API, you don't have to install any APP in your control comuter. They are controlled via SCPI commands through USB connections. The range of the outputs are of course different. |
|
We discussed the PR in the maintenance team. Our prefered solution is to generalize your code such that every device fullfilling the ProcessControlInterface can fullfill the SwitchInterface. We will look into this and keep this PR pending meanwhile. |
|
Thanks |
|
Dear @liuyanulm , Since there now is the switch functionality for all ProcessControlInterface Hardware through PR #37 could you maybe incoorporate these changes in your PR? |
add a hardware file to control the Keysight power supply.
Using the keysight power supply for power switches, so that one can control devices such as APD, MINI amplifers etc remotely.
Description
coded the hardware file of the Keysight power supply in the format of
switches, it works pretty well.Motivation and Context
With this change, you can switch on your APDs and amplifiers and other devices remotely.
How Has This Been Tested?
it was tested on the latest
iqo-qudi-moduleson a Windows 10 PC with a Keysight E36234A power supply.Screenshots (only if appropriate, delete if not):
Types of changes
Checklist:
/docs/changelog.md.(syntax, indentation, mutable default values, etc.).