Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I played around with qudi-core and the dummies in qudi-iqo-modules trying to make them compatible with PySide6/Qt6.
Most changes are either
from PySide2 import ...
withfrom PySide6 import ...
QtWidgets.QAction
withQtGui.QAction
self.DockWidgetFloatable
had to be changed toQtWidgets.QDockWidget.DockWidgetFloatable
to get it workingThe more complicated changes are in 63a0a4f affecting the POI manager and the pulsed toolchain. Some signals seem to have changed in Qt6. Since I don't know the modules very well, I am not sure if the changes I made don't break anything. As an example, I found that I cannot delete POIs in the dummy anymore.
Motivation and Context
I am sure that there are many good reasons to eventually transition to PySide6. Personally, I was motivated to play around with this since I am mostly developing on a laptop with Apple Silicon processor which does not support PySide2.
How Has This Been Tested?
Not very thoroughly: I loaded all dummy modules in the default config and pressed a few buttons at random.
Types of changes
Checklist:
/docs/changelog.md
.(syntax, indentation, mutable default values, etc.).