-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get last 5.7 fixes #19224
Get last 5.7 fixes #19224
Conversation
We now ignore the auto-centering of meshes for children objects, because it messes up with their relative position with their parent. Only the top-level objects needs to be centered, the children will follow. CURA-11902
Following the removal of the get/setMessage methods in the Job class, the StartSliceJob has not been updated and still used them. We now use a specific variable for storing the disabled extruders and properly display them. CURA-11904
The node_matrix is defined in the following if whatever the condition, so there is no need to define it first. CURA-11902
…t_mesh_position CURA-11902 fix loaded support mesh position
…xtruder_disabled CURA-11904 Fix crash when slicing with first extruder disabled
…for-raft-remove-inside-corner Added resolve function to take the values from material profiles
…rime_tower_from_material CURA-11931 set interleaved prime tower from material
Previously the material_print_temp_prepend and material_print_temp_wait were ignored for Griffin-flavored printers. Now we do handle them because we want the prepend, but we don't want the wait so disable it.
Updated Changelog for Cura 5.7.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
"material_print_temperature": { "minimum_value": "0" }, | ||
"material_standby_temperature": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding material_print_temperature as it belongs to material temperature catagory and shouldn't be placed in machine definitions
"material_print_temperature": { "minimum_value": "0" }, | |
"material_standby_temperature": | |
"material_standby_temperature": |
@@ -80,6 +80,7 @@ | |||
"maximum_value_warning": "120", | |||
"minimum_value": "0" | |||
}, | |||
"material_print_temp_wait": { "value": false }, | |||
"material_print_temperature": { "minimum_value": "0" }, | |||
"material_standby_temperature": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding material_standby_temperature as it belongs to material temperature catagory and shouldn't be placed in machine definitions
51c3340
to
044cc00
Compare
I actually reverted the version bump of twisted on main, because this is a mistake I made 😞 but it doesn't hurt... |
Ah sorry, I didn't see that 😓 --- like you said, it doesn't hurt at the moment, so I'll leave it in for now. |
No description provided.