Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get last 5.7 fixes #19224

Merged
merged 21 commits into from
Jun 12, 2024
Merged

Get last 5.7 fixes #19224

merged 21 commits into from
Jun 12, 2024

Conversation

wawanbreton
Copy link
Contributor

No description provided.

saumyaj3 and others added 19 commits May 8, 2024 14:31
We now ignore the auto-centering of meshes for children objects, because it messes up with their relative position with their parent. Only the top-level objects needs to be centered, the children will follow.

CURA-11902
Following the removal of the get/setMessage methods in the Job class, the StartSliceJob has not been updated and still used them. We now use a specific variable for storing the disabled extruders and properly display them.

CURA-11904
The node_matrix is defined in the following if whatever the condition, so there is no need to define it first.

CURA-11902
…t_mesh_position

CURA-11902 fix loaded support mesh position
…xtruder_disabled

CURA-11904 Fix crash when slicing with first extruder disabled
…for-raft-remove-inside-corner

Added resolve function to take the values from material profiles
…rime_tower_from_material

CURA-11931 set interleaved prime tower from material
Previously the material_print_temp_prepend and material_print_temp_wait were ignored for Griffin-flavored printers. Now we do handle them because we want the prepend, but we don't want the wait so disable it.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Comment on lines 84 to 85
"material_print_temperature": { "minimum_value": "0" },
"material_standby_temperature":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-material-temperature-defined ⚠️
Overriding material_print_temperature as it belongs to material temperature catagory and shouldn't be placed in machine definitions

Suggested change
"material_print_temperature": { "minimum_value": "0" },
"material_standby_temperature":
"material_standby_temperature":

@@ -80,6 +80,7 @@
"maximum_value_warning": "120",
"minimum_value": "0"
},
"material_print_temp_wait": { "value": false },
"material_print_temperature": { "minimum_value": "0" },
"material_standby_temperature":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-material-temperature-defined ⚠️
Overriding material_standby_temperature as it belongs to material temperature catagory and shouldn't be placed in machine definitions

@rburema rburema dismissed github-actions[bot]’s stale review June 12, 2024 11:30

outside of changed code

@wawanbreton
Copy link
Contributor Author

I actually reverted the version bump of twisted on main, because this is a mistake I made 😞 but it doesn't hurt...

@rburema
Copy link
Member

rburema commented Jun 12, 2024

I actually reverted the version bump of twisted on main, because this is a mistake I made 😞 but it doesn't hurt...

Ah sorry, I didn't see that 😓 --- like you said, it doesn't hurt at the moment, so I'll leave it in for now.

@rburema rburema merged commit a935026 into main Jun 12, 2024
7 checks passed
@rburema rburema deleted the 5.7-merge-to-main branch June 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants