Improve self support for Method machines #19286

pkuiper-ultimaker · 2024-06-25T16:08:21Z

PP-490

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (1/18)

resources/definitions/ultimaker_method_base.def.json

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (2/18)

resources/definitions/ultimaker_method_base.def.json

resources/quality/ultimaker_methodx/um_methodx_1c_um-abscf-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (3/18)

resources/quality/ultimaker_methodx/um_methodx_1c_um-abscf-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodx/um_methodx_1c_um-absr-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (4/18)

resources/quality/ultimaker_methodx/um_methodx_1c_um-absr-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodx/um_methodx_1c_um-asa-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (5/18)

resources/quality/ultimaker_methodx/um_methodx_1c_um-asa-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodx/um_methodx_1c_um-nylon12-cf-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (6/18)

resources/quality/ultimaker_methodx/um_methodx_1c_um-nylon12-cf-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodx/um_methodx_1xa_um-absr-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (7/18)

resources/quality/ultimaker_methodx/um_methodx_1xa_um-absr-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodx/um_methodx_1xa_um-asa-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodx/um_methodx_labs_um-abscf-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (8/18)

resources/quality/ultimaker_methodx/um_methodx_labs_um-abscf-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodx/um_methodx_labs_um-absr-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (9/18)

resources/quality/ultimaker_methodx/um_methodx_labs_um-absr-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodx/um_methodx_labs_um-asa-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodx/um_methodx_labs_um-nylon12-cf-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (10/18)

resources/quality/ultimaker_methodx/um_methodx_labs_um-nylon12-cf-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (11/18)

resources/quality/ultimaker_methodx/um_methodx_labs_um-nylon12-cf-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_1c_um-abscf-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (12/18)

resources/quality/ultimaker_methodxl/um_methodxl_1c_um-abscf-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_1c_um-absr-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_1c_um-asa-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (13/18)

resources/quality/ultimaker_methodxl/um_methodxl_1c_um-asa-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_1c_um-nylon12-cf-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (14/18)

resources/quality/ultimaker_methodxl/um_methodxl_1c_um-nylon12-cf-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_1xa_um-absr-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (15/18)

resources/quality/ultimaker_methodxl/um_methodxl_1xa_um-absr-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_1xa_um-asa-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_labs_um-abscf-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (16/18)

resources/quality/ultimaker_methodxl/um_methodxl_labs_um-abscf-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_labs_um-absr-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (17/18)

resources/quality/ultimaker_methodxl/um_methodxl_labs_um-absr-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_labs_um-asa-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_labs_um-nylon12-cf-175_0.2mm.inst.cfg

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (18/18)

resources/quality/ultimaker_methodxl/um_methodxl_labs_um-nylon12-cf-175_0.2mm.inst.cfg

wawanbreton

Sorry for the 100s of false warnings... I made a fix for the printer-linter.
Apart from that, just a few minor remarks/suggestions.

resources/definitions/ultimaker_method_base.def.json

resources/quality/ultimaker_methodx/um_methodx_1c_um-abscf-175_0.2mm.inst.cfg

Co-authored-by: Erwan MATHIEU <erwan.mathieu@ultimaker.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json

…his value was in the base definition file PP-490

PP-490

…pport

Improve self support for Method machines

853c21d

pkuiper-ultimaker requested a review from alanbjorklund June 25, 2024 16:08

github-actions bot requested changes Jun 25, 2024

View reviewed changes

wawanbreton requested changes Jun 28, 2024

View reviewed changes

wawanbreton and others added 5 commits June 28, 2024 15:58

Merge branch 'main' into PP-490-Method-Self-Support

7623bf8

Update resources/definitions/ultimaker_method_base.def.json

fb274df

Co-authored-by: Erwan MATHIEU <erwan.mathieu@ultimaker.com>

Update resources/definitions/ultimaker_method_base.def.json

5857f37

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update resources/definitions/ultimaker_method_base.def.json

828362d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Applied printer-linter format

637d516

github-actions bot requested changes Jun 28, 2024

View reviewed changes

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved

resources/definitions/ultimaker_method_base.def.json Show resolved Hide resolved

resources/definitions/ultimaker_method_base.def.json Show resolved Hide resolved

alanbjorklund and others added 3 commits June 28, 2024 11:06

removed support_z_distance = 0 from soluble material quality files, t…

df04127

…his value was in the base definition file PP-490

Applied printer-linter format

ec452d6

Merge branch 'main' into PP-490-Method-Self-Support

9f9375a

wawanbreton and others added 4 commits July 1, 2024 15:24

Merge branch 'main' into PP-490-Method-Self-Support

bd94ab7

Merge branch 'main' into PP-490-Method-Self-Support

6523cd5

Update PR with latest changes from main.

c771424

PP-490

Merge remote-tracking branch 'origin/main' into PP-490-Method-Self-Su…

e7f768f

…pport

wawanbreton approved these changes Jul 4, 2024

View reviewed changes

HellAholic merged commit 5d963fa into main Jul 5, 2024
10 of 12 checks passed

HellAholic deleted the PP-490-Method-Self-Support branch July 5, 2024 06:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve self support for Method machines #19286

Improve self support for Method machines #19286

pkuiper-ultimaker commented Jun 25, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

wawanbreton left a comment

github-actions bot left a comment

Improve self support for Method machines #19286

Improve self support for Method machines #19286

Conversation

pkuiper-ultimaker commented Jun 25, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

wawanbreton left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment