Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a fuzz harness and oss-fuzz build configuration #1877

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

nathaniel-brough
Copy link

@nathaniel-brough nathaniel-brough commented Apr 24, 2023

Description

This PR adds a fuzz testing harness and the necessary build configurations, to get CuraEngine integrated into oss-fuzz. This is in initial integration as a follow up on #1603.

See corresponding draft integration PR here google/oss-fuzz#10155

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This PR does not add any new functionality instead it adds ONLY fuzz testing harnesses.

  • FuzzGcodeExport, fuzzes the gcode export library with randomized inputs.

Test Configuration:

  • Operating System:

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Apr 24, 2023
@nathaniel-brough
Copy link
Author

nathaniel-brough commented Apr 24, 2023

cc @nallath as you are listed as primary contact for oss-fuzz configs :)

@nathaniel-brough
Copy link
Author

@jellespijker Friendly ping :) I need to work through some of the other conflicts that I've merged incorrectly. Before I do that, is this PR of any interest?

@jellespijker
Copy link
Member

Hi @silvergasp

Apologize for taking this long to reply. My GitHub notification probably got lost in the 600+ notifications if I'm working on GH actions and I get the failed run notification.

At a first glance I would say, yes Fuzz testing is something that we want I will bring this up with the team such that we can plan the review and testing in our sprint

@jellespijker jellespijker self-assigned this Feb 16, 2024
@jellespijker jellespijker added the PR: Automation and build 🤖 Improving CI/CT/CD workflows label Feb 16, 2024
@nathaniel-brough
Copy link
Author

Not a problem, let me know if you have any further queries regarding this PR/oss-fuzz or just more generally about fuzzing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Automation and build 🤖 Improving CI/CT/CD workflows PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants