Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CuraEngine wasm with pthread support #2128

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jellespijker
Copy link
Member

Revised target_link_options for better readability and maintainability by using the "SHELL:" prefix for each option. Additionally, removed the ENABLE_THREADING variable from conanfile.py as threading support is now handled directly in the build options.

Contribute to NP-334

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

  • Operating System:

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change

Revised target_link_options for better readability and maintainability by using the "SHELL:" prefix for each option. Additionally, removed the ENABLE_THREADING variable from conanfile.py as threading support is now handled directly in the build options.

Contribute to NP-334
Contribute to NP-334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant