Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dongle doesn't reconnect #1023

Open
mondalaci opened this issue Nov 20, 2024 · 8 comments
Open

Dongle doesn't reconnect #1023

mondalaci opened this issue Nov 20, 2024 · 8 comments

Comments

@mondalaci
Copy link
Member

I pair the dongle, then disconnect it from the USB and reconnect it via USB. Now, the blue light is on, and it doesn't connect to the UHK anymore. - copy-pasted from UltimateHackingKeyboard/agent80#135 (comment)

@mondalaci
Copy link
Member Author

I also want to add that the dongle LED should only switch to green if HID reports are routed between the UHK and the dongle. I'm sure this is the expected behavior from the user's standpoint. Consider using multiple dongles and figuring out which one is currently used by the UHK. I can create a separate issue for this.

@mondalaci
Copy link
Member Author

Restarting the right half makes the dongle LED go green and function well.

@kareltucek
Copy link
Collaborator

kareltucek commented Nov 23, 2024

I can't reproduce this.

I also want to add that the dongle LED should only switch to green if HID reports are routed between the UHK and the dongle. I'm sure this is the expected behavior from the user's standpoint.

What about adding a yellow state to indicate the difference between connected and routing? (Not sure how exactly the colors should be assigned though.

Maybe:

  • red = disconnected
  • yellow = disconnected, but paired
  • blue = ready
  • green = routing

@mondalaci
Copy link
Member Author

Now, my dongle LED is green, and my UHK is connected via USB, so the HID reports aren't routed to my dongle. Can't you reproduce it?

@kareltucek
Copy link
Collaborator

I wasnt referring to routing color.

I was referring to the report that dongle doesnt connect until right is restarted.

@mondalaci
Copy link
Member Author

Now, I can't reproduce the original issue either.

The naming of the proposed "disconnected but paired" state doesn't make sense to me. Naming it "connected but not routing" would make sense to me. Maybe I'm missing something, so feel free to explain.

@kareltucek
Copy link
Collaborator

Well, they are two different states. Currently, I operate with the simpler implementation that keeps both connections alive and only switches routing.

  • red = disconnected, right half address is not set
  • violet = not connected, right half address is set -> trying to connect
  • blue = connected, but we are not the target host connection
  • green = connected, we are the target host connection

@mondalaci
Copy link
Member Author

Please implement the suggested violet state and let's see how it works out.

@mondalaci mondalaci transferred this issue from UltimateHackingKeyboard/firmware80 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants