Skip to content
This repository has been archived by the owner on Dec 15, 2024. It is now read-only.

fix: allow to delete host connection when dongle is not connected #135

Merged
merged 5 commits into from
Nov 21, 2024
Merged

fix: allow to delete host connection when dongle is not connected #135

merged 5 commits into from
Nov 21, 2024

Conversation

ert78gb
Copy link
Member

@ert78gb ert78gb commented Nov 9, 2024

No description provided.

@ert78gb ert78gb requested a review from mondalaci November 9, 2024 16:40
@ert78gb ert78gb force-pushed the fix-allow-delete-host-connection-when-dongle-not-connected branch from 980cb37 to a422025 Compare November 14, 2024 18:02
@mhantsch
Copy link

Should I try this branch build to see if I can get my Dongle connected/paired again? At the moment, when I connect the Dongle to USB, and unplug the UHK from USB, the UHK will say "Dongle" but will not send any keystrokes or mouse movements. I guess I have to repair it to the Dongle, but the Dongle doesn't even show up in Agent.

@kareltucek
Copy link
Contributor

, but the Dongle doesn't even show up in Agent.

That's strange. What does dmesg say when you plug it in?

@ert78gb
Copy link
Member Author

ert78gb commented Nov 15, 2024

What is the output of the Agent when you start with -- --print-usb-devices argument?

@mhantsch
Copy link

dmesg (what I regard as relevant parts):

[437460.983997] usb 3-4: new full-speed USB device number 77 using xhci_hcd
[437461.388642] usb 3-4: New USB device found, idVendor=37a8, idProduct=0005, bcdDevice= 0.01
[437461.388656] usb 3-4: New USB device strings: Mfr=255, Product=254, SerialNumber=253
[437461.388660] usb 3-4: Product: UHK dongle
[437461.388664] usb 3-4: Manufacturer: Ultimate Gadget Laboratories
[437461.388667] usb 3-4: SerialNumber: 0000000000
[437461.397051] input: Ultimate Gadget Laboratories UHK dongle as /devices/pci0000:00/0000:00:14.0/usb3/3-4/3-4:1.0/0003:37A8:0005.00F8/input/input398
[437461.449816] hid-generic 0003:37A8:0005.00F8: input,hidraw13: USB HID v1.11 Keyboard [Ultimate Gadget Laboratories UHK dongle] on usb-0000:00:14.0-4/input0
[437461.452613] input: Ultimate Gadget Laboratories UHK dongle as /devices/pci0000:00/0000:00:14.0/usb3/3-4/3-4:1.1/0003:37A8:0005.00F9/input/input399
[437461.453356] hid-generic 0003:37A8:0005.00F9: input,hidraw15: USB HID v1.11 Mouse [Ultimate Gadget Laboratories UHK dongle] on usb-0000:00:14.0-4/input1
[437461.456213] hid-generic 0003:37A8:0005.00FA: hiddev4,hidraw16: USB HID v1.11 Device [Ultimate Gadget Laboratories UHK dongle] on usb-0000:00:14.0-4/input2
[437461.459060] input: Ultimate Gadget Laboratories UHK dongle as /devices/pci0000:00/0000:00:14.0/usb3/3-4/3-4:1.3/0003:37A8:0005.00FB/input/input400
[437461.512576] hid-generic 0003:37A8:0005.00FB: input,hidraw17: USB HID v1.11 Device [Ultimate Gadget Laboratories UHK dongle] on usb-0000:00:14.0-4/input3
[437461.515666] input: Ultimate Gadget Laboratories UHK dongle as /devices/pci0000:00/0000:00:14.0/usb3/3-4/3-4:1.4/0003:37A8:0005.00FC/input/input401
[437461.516029] hid-generic 0003:37A8:0005.00FC: input,hidraw18: USB HID v1.11 Gamepad [Ultimate Gadget Laboratories UHK dongle] on usb-0000:00:14.0-4/input4

and `lsusb' shows it as:

Bus 003 Device 077: ID 37a8:0005 Ultimate Gadget Laboratories UHK dongle

So it's certainly connected, and the kernel knows about it.

I'll check Agent later, I have to go somewhere now.

@mhantsch
Copy link

Actually, here's Agent's output:

(base) max@max-framework:~$ ~/Downloads/UHK.Agent-4.2.1-linux-x86_64-good.AppImage -- --print-usb-devices
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.

(AppImageLauncher:1503588): GLib-CRITICAL **: 13:01:28.397: g_file_test: assertion 'filename != NULL' failed
13:01:30.978 › [Electron Main] command line arguments { 'print-usb-devices': true }
13:01:30.984 › [Electron Main] init services.
13:01:30.984 › [Electron Main] packagesDir: /tmp/.mount_UHK.AgoQyvd6/resources
[
  {
    vendorId: 4401,
    productId: 13569,
    path: '/dev/hidraw12',
    serialNumber: '00:11:67:52:15:dd',
    manufacturer: '',
    product: 'Bluetooth Optic Mouse',
    release: 0,
    interface: -1,
    usagePage: 1,
    usage: 2
  },
  {
    vendorId: 4401,
    productId: 13569,
    path: '/dev/hidraw12',
    serialNumber: '00:11:67:52:15:dd',
    manufacturer: '',
    product: 'Bluetooth Optic Mouse',
    release: 0,
    interface: -1,
    usagePage: 1,
    usage: 1
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw3',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 0,
    usagePage: 1,
    usage: 6
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw4',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 1,
    usagePage: 1,
    usage: 2
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw4',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 1,
    usagePage: 1,
    usage: 1
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw4',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 1,
    usagePage: 12,
    usage: 1
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw4',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 1,
    usagePage: 12,
    usage: 1
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw5',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 2,
    usagePage: 12,
    usage: 1
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw5',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 2,
    usagePage: 12,
    usage: 1
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw5',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 2,
    usagePage: 1,
    usage: 128
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw5',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 2,
    usagePage: 65468,
    usage: 136
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw5',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 2,
    usagePage: 1,
    usage: 6
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw6',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 3,
    usagePage: 65290,
    usage: 1
  },
  {
    vendorId: 10007,
    productId: 59,
    path: '/dev/hidraw6',
    serialNumber: '',
    manufacturer: 'MI Dongle',
    product: 'MI Wireless Mouse',
    release: 1,
    interface: 3,
    usagePage: 65290,
    usage: 2
  },
  {
    vendorId: 14248,
    productId: 9,
    path: '/dev/hidraw7',
    serialNumber: '1736713552',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK 80 right half',
    release: 1,
    interface: 0,
    usagePage: 1,
    usage: 6
  },
  {
    vendorId: 14248,
    productId: 9,
    path: '/dev/hidraw8',
    serialNumber: '1736713552',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK 80 right half',
    release: 1,
    interface: 1,
    usagePage: 1,
    usage: 2
  },
  {
    vendorId: 14248,
    productId: 9,
    path: '/dev/hidraw8',
    serialNumber: '1736713552',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK 80 right half',
    release: 1,
    interface: 1,
    usagePage: 1,
    usage: 1
  },
  {
    vendorId: 14248,
    productId: 9,
    path: '/dev/hidraw10',
    serialNumber: '1736713552',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK 80 right half',
    release: 1,
    interface: 2,
    usagePage: 65280,
    usage: 1
  },
  {
    vendorId: 14248,
    productId: 9,
    path: '/dev/hidraw11',
    serialNumber: '1736713552',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK 80 right half',
    release: 1,
    interface: 3,
    usagePage: 12,
    usage: 1
  },
  {
    vendorId: 14248,
    productId: 9,
    path: '/dev/hidraw19',
    serialNumber: '1736713552',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK 80 right half',
    release: 1,
    interface: 4,
    usagePage: 1,
    usage: 5
  },
  {
    vendorId: 12972,
    productId: 2,
    path: '/dev/hidraw2',
    serialNumber: '11AD1D00C9942F183A160B00',
    manufacturer: 'Framework',
    product: 'HDMI Expansion Card',
    release: 0,
    interface: 1,
    usagePage: 65518,
    usage: 1
  },
  {
    vendorId: 14248,
    productId: 5,
    path: '/dev/hidraw13',
    serialNumber: '0000000000',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK dongle',
    release: 1,
    interface: 0,
    usagePage: 1,
    usage: 6
  },
  {
    vendorId: 14248,
    productId: 5,
    path: '/dev/hidraw15',
    serialNumber: '0000000000',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK dongle',
    release: 1,
    interface: 1,
    usagePage: 1,
    usage: 2
  },
  {
    vendorId: 14248,
    productId: 5,
    path: '/dev/hidraw15',
    serialNumber: '0000000000',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK dongle',
    release: 1,
    interface: 1,
    usagePage: 1,
    usage: 1
  },
  {
    vendorId: 14248,
    productId: 5,
    path: '/dev/hidraw16',
    serialNumber: '0000000000',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK dongle',
    release: 1,
    interface: 2,
    usagePage: 65280,
    usage: 1
  },
  {
    vendorId: 14248,
    productId: 5,
    path: '/dev/hidraw17',
    serialNumber: '0000000000',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK dongle',
    release: 1,
    interface: 3,
    usagePage: 12,
    usage: 1
  },
  {
    vendorId: 14248,
    productId: 5,
    path: '/dev/hidraw18',
    serialNumber: '0000000000',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK dongle',
    release: 1,
    interface: 4,
    usagePage: 1,
    usage: 5
  },
  {
    vendorId: 19024,
    productId: 17748,
    path: '/dev/hidraw20',
    serialNumber: '',
    manufacturer: 'JPConstantineau.com',
    product: 'ErgoTravel Keyboard',
    release: 256,
    interface: 0,
    usagePage: 1,
    usage: 6
  },
  {
    vendorId: 19024,
    productId: 17748,
    path: '/dev/hidraw21',
    serialNumber: '',
    manufacturer: 'JPConstantineau.com',
    product: 'ErgoTravel Keyboard',
    release: 256,
    interface: 1,
    usagePage: 1,
    usage: 2
  },
  {
    vendorId: 19024,
    productId: 17748,
    path: '/dev/hidraw21',
    serialNumber: '',
    manufacturer: 'JPConstantineau.com',
    product: 'ErgoTravel Keyboard',
    release: 256,
    interface: 1,
    usagePage: 1,
    usage: 1
  },
  {
    vendorId: 19024,
    productId: 17748,
    path: '/dev/hidraw21',
    serialNumber: '',
    manufacturer: 'JPConstantineau.com',
    product: 'ErgoTravel Keyboard',
    release: 256,
    interface: 1,
    usagePage: 1,
    usage: 128
  },
  {
    vendorId: 19024,
    productId: 17748,
    path: '/dev/hidraw21',
    serialNumber: '',
    manufacturer: 'JPConstantineau.com',
    product: 'ErgoTravel Keyboard',
    release: 256,
    interface: 1,
    usagePage: 12,
    usage: 1
  },
  {
    vendorId: 3468,
    productId: 258,
    path: '/dev/hidraw14',
    serialNumber: '',
    product: 'USB Sound Device        ',
    release: 16,
    interface: 3,
    usagePage: 12,
    usage: 1
  },
  {
    vendorId: 12972,
    productId: 6,
    path: '/dev/hidraw0',
    serialNumber: '',
    manufacturer: '',
    product: 'FRMW0001:00 32AC:0006',
    release: 0,
    interface: -1,
    usagePage: 1,
    usage: 12
  },
  {
    vendorId: 12972,
    productId: 6,
    path: '/dev/hidraw0',
    serialNumber: '',
    manufacturer: '',
    product: 'FRMW0001:00 32AC:0006',
    release: 0,
    interface: -1,
    usagePage: 12,
    usage: 1
  },
  {
    vendorId: 12972,
    productId: 6,
    path: '/dev/hidraw0',
    serialNumber: '',
    manufacturer: '',
    product: 'FRMW0001:00 32AC:0006',
    release: 0,
    interface: -1,
    usagePage: 32,
    usage: 65
  },
  {
    vendorId: 12972,
    productId: 6,
    path: '/dev/hidraw0',
    serialNumber: '',
    manufacturer: '',
    product: 'FRMW0001:00 32AC:0006',
    release: 0,
    interface: -1,
    usagePage: 32,
    usage: 777
  },
  {
    vendorId: 12972,
    productId: 6,
    path: '/dev/hidraw0',
    serialNumber: '',
    manufacturer: '',
    product: 'FRMW0001:00 32AC:0006',
    release: 0,
    interface: -1,
    usagePage: 32,
    usage: 790
  },
  {
    vendorId: 12972,
    productId: 6,
    path: '/dev/hidraw0',
    serialNumber: '',
    manufacturer: '',
    product: 'FRMW0001:00 32AC:0006',
    release: 0,
    interface: -1,
    usagePage: 32,
    usage: 793
  },
  {
    vendorId: 12972,
    productId: 6,
    path: '/dev/hidraw0',
    serialNumber: '',
    manufacturer: '',
    product: 'FRMW0001:00 32AC:0006',
    release: 0,
    interface: -1,
    usagePage: 32,
    usage: 513
  },
  {
    vendorId: 12972,
    productId: 6,
    path: '/dev/hidraw0',
    serialNumber: '',
    manufacturer: '',
    product: 'FRMW0001:00 32AC:0006',
    release: 0,
    interface: -1,
    usagePage: 32,
    usage: 513
  },
  {
    vendorId: 12972,
    productId: 6,
    path: '/dev/hidraw0',
    serialNumber: '',
    manufacturer: '',
    product: 'FRMW0001:00 32AC:0006',
    release: 0,
    interface: -1,
    usagePage: 32,
    usage: 514
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 1,
    usage: 2
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 1,
    usage: 1
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 13,
    usage: 5
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 13,
    usage: 34
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 13,
    usage: 34
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 13,
    usage: 34
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 13,
    usage: 34
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 13,
    usage: 34
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 13,
    usage: 14
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 13,
    usage: 34
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 13,
    usage: 34
  },
  {
    vendorId: 2362,
    productId: 628,
    path: '/dev/hidraw1',
    serialNumber: '',
    manufacturer: '',
    product: 'PIXA3854:00 093A:0274',
    release: 0,
    interface: -1,
    usagePage: 65280,
    usage: 1
  }
]

@ert78gb
Copy link
Member Author

ert78gb commented Nov 15, 2024 •
edited
Loading

The dongle communication interface in the list. Agent should communicate with it.

{
    vendorId: 14248,
    productId: 5,
    path: '/dev/hidraw16',
    serialNumber: '0000000000',
    manufacturer: 'Ultimate Gadget Laboratories',
    product: 'UHK dongle',
    release: 1,
    interface: 2,
    usagePage: 65280,
    usage: 1
  },

This PR fixes some bug.
We are discussing some use-cases internally that may will affect the final version of this PR. My opinion is safe to use this PR

@mondalaci
Copy link
Member

mondalaci commented Nov 15, 2024 •
edited
Loading

@kareltucek Robi told me that upon removing host connections, Agent deletes the dongle's connection info whenever the dongle is present. If the dongle is not present, the connection info stored on it is preserved. I think connection info shouldn't be deleted on the dongle for the sake of consistency, only in the right half. Agreed?

@kareltucek
Copy link
Contributor

Alright.

@mondalaci
Copy link
Member

@ert78gb Then please don't delete the connection info on the dongle upon deleting its host connection, even if it's connected.

@mondalaci
Copy link
Member

@kareltucek I am experiencing the following issues, which may be (partially) firmware-related. Please comment on them.

  1. I pair the dongle, then disconnect it from the USB and reconnect it via USB. Now, the blue light is on, and it doesn't connect to the UHK anymore.
  2. When pairing is deleted, the dongle LED is blue, suggesting that it's paired, instead of being red, suggesting that it's unpaired, which is the case. I know that the pairing is not deleted in the dongle, so technically, blue is correct, but from a user standpoint, it should be red. How do we resolve this issue? One solution is that whenever Agent notices that the pairing is deleted on the UHK side and not on the dongle side, it automatically deletes the bond on the dongle.

@mhantsch
Copy link

2. One solution is that whenever Agent notices that the pairing is deleted on the UHK side and not on the dongle side, it automatically deletes the bond on the dongle.

How would Agent know that this Dongle is the Dongle that used to be paired to the UHK that Agent is currently talking to, and not a Dongle paired to a different UHK which is currently not connected? Imagine I had two UHK80s, and two Dongles (one for each keyboard). If I leave Dongle A (paired to UHK A) plugged in, and connect UHK B via USB, how would Agent know not to delete the pairing to UHK A from Dongle A?

@kareltucek
Copy link
Contributor

@mondalaci will look into it. Have experienced it before, but was unclear on how to reproduce it.

@mhantsch we provide ble addresses via usb commands.

  1. When pairing is deleted, the dongle LED is blue, suggesting that it's paired, instead of being red, suggesting that it's unpaired, which is the case. I know that the pairing is not deleted in the dongle, so technically, blue is correct, but from a user standpoint, it should be red. How do we resolve this issue? One solution is that whenever Agent notices that the pairing is deleted on the UHK side and not on the dongle side, it automatically deletes the bond on the dongle.

Well, I guess Agent should again unpair the dongle whenever deleting a host connection when the dongle is connected.

Furthermore, whenever Agent notices a new dongle, it should ask to whom it is paired, and if it is the currently connected keyboard, then check whether the uhk is paired to it, and if no, then delete the connection on the dongle.

@mondalaci
Copy link
Member

@ert78gb Let's do as Karel suggested.

@kareltucek Should I create a firmware issue for this?

@kareltucek
Copy link
Contributor

Feel free to.

@mondalaci mondalaci mentioned this pull request Nov 20, 2024
Open
@ert78gb
Copy link
Member Author

ert78gb commented Nov 20, 2024 •
edited
Loading

Well, I guess Agent should again unpair the dongle whenever deleting a host connection when the dongle is connected.

Am I understanding well, technically I have to revert my last commit. Because it was the earlier behaviour.

Furthermore, whenever Agent notices a new dongle, it should ask to whom it is paired, and if it is the currently connected keyboard, then check whether the uhk is paired to it, and if no, then delete the connection on the dongle.

Should we overcomplicated it? I mean when Agent detects the dongle is not paired with the keyboard then it offer to pair it.
Agent checks the HostConnections array and asks the keyboard is it paired with the Dongle vice versa.
The opposite has not checked. Should Agent checks?

If the user deletes a host connection when Dongle is not connected then Agent can't delete the bonds from the Dongle.
Next time when the user plugs in the Dongle the LED will be blue because it has bond.
My general personal preference is minimalise the automatism so I don't prefer the automatic bond deletion from the Dongle.
Max mentioned 1 use case.
I think this Dongle pairing / unpairing is a rarely used function

" ask to whom it is paired" @kareltucek do you mean Agent should use the IsPaired (0x1b) USB command on the Dongle with the keyboard BLE address?

@mondalaci
Copy link
Member

Yes, please revert your commit.

Based on our chat, please don't delete the bonds on dongles that weren't deleted because they were disconnected when deleting their host connection. It's a rare situation, and if someone is bothered by the LED color, they can pair the dongle and delete the pairing while the dongle is connected.

@kareltucek
Copy link
Contributor

" ask to whom it is paired" @kareltucek do you mean Agent should use the IsPaired (0x1b) USB command on the Dongle with the keyboard BLE address?

I meant the new 0 10 get device property command:

        DevicePropertyId_PairedRightPeerBleAddress = 10,

@ert78gb ert78gb force-pushed the fix-allow-delete-host-connection-when-dongle-not-connected branch from 0d6a586 to d28cba0 Compare November 21, 2024 19:43
@ert78gb
Copy link
Member Author

ert78gb commented Nov 21, 2024

reverted the last commit and rebased the branch

@mondalaci
Copy link
Member

My dongle is connected, and after deleting its connection, its LED doesn't go red, not even when reconnected via USB.

@kareltucek Please confirm this issue and provide instructions to Robi.

@mondalaci mondalaci merged commit 22cd23c into master Nov 21, 2024
3 checks passed
@mondalaci mondalaci deleted the fix-allow-delete-host-connection-when-dongle-not-connected branch November 21, 2024 23:07
@mondalaci
Copy link
Member

Agent works as expected. Opening a firmware issue about the dongle LED update.

@mondalaci mondalaci mentioned this pull request Nov 9, 2024
Open
@ert78gb ert78gb mentioned this pull request Nov 14, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mondalaci mondalaci Awaiting requested review from mondalaci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ert78gb @mhantsch @kareltucek @mondalaci