Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

WIP: Implement some power-consumption optimizations. #303

Merged
merged 1 commit into from
Oct 6, 2024
Merged

WIP: Implement some power-consumption optimizations. #303

merged 1 commit into from
Oct 6, 2024

Conversation

kareltucek
Copy link
Contributor

This decreases the frequency of various scanning intervals when in sleep mode.

@kareltucek kareltucek force-pushed the power_consumption_optimizations branch from 2c7ae48 to ad865cc Compare October 2, 2024 22:14
@mondalaci
Copy link
Member

  1. I pair my Android phone via BLE. The UHK works fine via BLE.
  2. I unpair my phone.
  3. The UHK doesn't work via USB, so I must reboot the right half. This used to work but doesn't work anymore, not even on master. Should I bisect?
  4. On master, my key cluster keeps working. But with this PR, my key cluster doesn't work until I reboot the left half.

I won't merge this PR until 4. gets fixed.

@kareltucek kareltucek changed the title Implement some power-consumption optimizations. WIP: Implement some power-consumption optimizations. Oct 3, 2024
@kareltucek
Copy link
Contributor Author

All right, let's leave this for a time.

As to 3., I don't know if bisecting will tell us anything important, but unless you have a better means of debugging that, then yes please.

@mondalaci
Copy link
Member

Regarding issue 3, I opened #310.

Issue 4 doesn't seem to persists, so I'm merging this.

@mondalaci mondalaci merged commit 4adec3c into master Oct 6, 2024
1 check passed
@mondalaci mondalaci deleted the power_consumption_optimizations branch October 6, 2024 19:17
@kareltucek kareltucek restored the power_consumption_optimizations branch October 6, 2024 19:45
kareltucek added a commit that referenced this pull request Oct 6, 2024
@kareltucek
Revert "Merge pull request #303 from UltimateHackingKeyboard/power_co…
b24b176 
…nsumption_optimizations"

This reverts commit 4adec3c, reversing
changes made to 8c7d710.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kareltucek @mondalaci