Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Fix some pairing-related issues. #356

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix some pairing-related issues. #356

merged 1 commit into from
Nov 14, 2024

Conversation

kareltucek
Copy link
Contributor

This should some of the issues in UltimateHackingKeyboard/firmware#1019

I would appreciate a thorough review of this PR.

Also, this definitely doesn't solve all the problems, but should be a step in the right direction.

@kareltucek
Copy link
Contributor Author

@mhantsch this should make your uhk usable again. Could you maybe give it a try and let us know what problems you have encountered?

@mondalaci
Copy link
Member

The issue is fixed based on my tests. Should I merge this?

CONFIG_BT_MAX_CONN=4 and CONFIG_BT_MAX_PAIRED=20 seem overkill, though. Why so high values?

@kareltucek
Copy link
Contributor Author

If 20 is an overkill, then why do we have 22 host connection slots?

@kareltucek
Copy link
Contributor Author

The issue is fixed based on my tests. Should I merge this?

Yes please.

@mondalaci
Copy link
Member

CONFIG_BT_MAX_PAIRED is justified, indeed, by the maximum number of paired wireless connections (which is admittedly rather overkill but might be used by some users).

Please explain why CONFIG_BT_MAX_CONN=4 is needed.

@kareltucek
Copy link
Contributor Author

If we want uhk80 to act as a kvm switch, we need at least two active host connections, plus connection to left half, plus one free connection so that we can keep advertising and do connection-priority magic.

@kareltucek kareltucek changed the title WIP: Fix some pairing-related issues. Fix some pairing-related issues. Nov 14, 2024
@mondalaci mondalaci merged commit af27aeb into master Nov 14, 2024
1 check passed
@mondalaci mondalaci deleted the bt_fixes branch November 14, 2024 13:59
@mhantsch
Copy link
Contributor

If we want uhk80 to act as a kvm switch, we need at least two active host connections, plus connection to left half, plus one free connection so that we can keep advertising and do connection-priority magic.

Can I pair a Bluetooth mouse to the UHK, and it will relay the mouse activities via the active UHK-to-host connection (BT, Dongle, USB left, USB right)? Then the UHK80 would be a true KM switch (no Video, so no V).

(Yeah I know, crazy idea, and yes, technically challenging, and yes, more pressing issues first!)

@mondalaci
Copy link
Member

I've already thought of that, but the mentioned feature will come much later.

@kareltucek
Copy link
Contributor Author

If we want uhk80 to act as a kvm switch, we need at least two active host connections, plus connection to left half, plus one free connection so that we can keep advertising and do connection-priority magic.

Can I pair a Bluetooth mouse to the UHK, and it will relay the mouse activities via the active UHK-to-host connection (BT, Dongle, USB left, USB right)? Then the UHK80 would be a true KM switch (no Video, so no V).

(Yeah I know, crazy idea, and yes, technically challenging, and yes, more pressing issues first!)

Looking forward to a PR ;-).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants