Transliterate search queries, remove GetStringWithNoAccents

Also rename -NoAccent fields to -ASCII

src/base/UCommon.pas

@@ -74,8 +74,6 @@ function StringDeleteFromArray(var InArray: TIntegerDynArray; const InIndex: int
 function StringDeleteFromArray(var InStrings: TStringDynArray; const InIndex: integer): Boolean; overload;
 function StringDeleteFromArray(var InStrings: TUTF8StringDynArray; const InIndex: integer): Boolean; overload;
 
-function GetStringWithNoAccents(str: String):String;
-
 type
   TRGB = record
     R: single;
@@ -224,24 +222,6 @@ function SplitString(const Str: string; MaxCount: integer; Separators: TSysCharS
     AddSplit(Start+1, Length(Str)+1);
 end;
 
-const
-  Accents: array [0..42] of String = ('ç', 'á', 'é', 'í', 'ó', 'ú', 'ý', 'à', 'è', 'ì', 'ò', 'ù', 'ã', 'õ', 'ñ', 'ä', 'ë', 'ï', 'ö', 'ü', 'ÿ', 'â', 'ê', 'î', 'ô', 'û', 'ą', 'ć', 'ł', 'ś', 'ź', '!', '¡', '"', '&', '(', ')', '?', '¿', ',', '.', ':', ';');
-  NoAccents: array [0..42] of String = ('c', 'a', 'e', 'i', 'o', 'u', 'y', 'a', 'e', 'i', 'o', 'u', 'a', 'o', 'n', 'a', 'e', 'i', 'o', 'u', 'y', 'a', 'e', 'i', 'o', 'u', 'a', 'c', 'l', 's', 'z', '', '', '', '', '', '', '', '', '', '', '', '');
-
-function GetStringWithNoAccents(str: String):String;
-var
-  i: integer;
-  tmp: string;
-begin
-  tmp := str;//Utf8ToAnsi(str);
-
-  for i := 0 to High(Accents) do
-  begin
-    str := StringReplace(str, Accents[i], NoAccents[i], [rfReplaceAll, rfIgnoreCase]);
-  end;
-
-  Result := str;
-end;
 
 function RGBToHex(R, G, B: integer): string;
 begin

src/base/USong.pas

@@ -52,7 +52,6 @@ interface
     PseudoThread,
   {$ENDIF}
   UCatCovers,
-  UCommon,
   UFilesystem,
   ULog,
   UPath,
@@ -139,12 +138,12 @@   TSong = class
     Artist:     UTF8String;
 
     // use in search
-    TitleNoAccent:    UTF8String;
-    ArtistNoAccent:   UTF8String;
-    LanguageNoAccent: UTF8String;
-    EditionNoAccent:  UTF8String;
-    GenreNoAccent:    UTF8String;
-    CreatorNoAccent:  UTF8String;
+    TitleASCII:    UTF8String;
+    ArtistASCII:   UTF8String;
+    LanguageASCII: UTF8String;
+    EditionASCII:  UTF8String;
+    GenreASCII:    UTF8String;
+    CreatorASCII:  UTF8String;
 
     Creator:    UTF8String;
 
@@ -224,7 +223,6 @@   TSongOptions = class
 implementation
 
 uses
-  iconvenc,
   StrUtils,
   TextGL,
   UIni,
@@ -916,14 +914,14 @@ function TSong.ReadXMLHeader(const aFileName : IPath): boolean;
 
     //Title
     self.Title := Parser.SongInfo.Header.Title;
-    self.TitleNoAccent := LowerCase(GetStringWithNoAccents(UTF8Decode(Parser.SongInfo.Header.Title)));
+    self.TitleASCII := LowerCase(TransliterateToASCII(UTF8Decode(self.Title)));
 
     //Add Title Flag to Done
     Done := Done or 1;
 
     //Artist
     self.Artist := Parser.SongInfo.Header.Artist;
-    self.ArtistNoAccent := LowerCase(GetStringWithNoAccents(UTF8Decode(Parser.SongInfo.Header.Artist)));
+    self.ArtistASCII := LowerCase(TransliterateToASCII(UTF8Decode(self.Artist)));
 
     //Add Artist Flag to Done
     Done := Done or 2;
@@ -965,18 +963,18 @@ function TSong.ReadXMLHeader(const aFileName : IPath): boolean;
 
     //Genre Sorting
     self.Genre := Parser.SongInfo.Header.Genre;
-    self.GenreNoAccent := LowerCase(GetStringWithNoAccents(UTF8Decode(self.Genre)));
+    self.GenreASCII := LowerCase(TransliterateToASCII(UTF8Decode(self.Genre)));
 
     //Edition Sorting
     self.Edition := Parser.SongInfo.Header.Edition;
-    self.EditionNoAccent := LowerCase(GetStringWithNoAccents(UTF8Decode(self.Edition)));
+    self.EditionASCII := LowerCase(TransliterateToASCII(UTF8Decode(self.Edition)));
 
     //Year Sorting
     //self.Year := Parser.SongInfo.Header.Year
 
     //Language Sorting
     self.Language := Parser.SongInfo.Header.Language;
-    self.LanguageNoAccent := LowerCase(GetStringWithNoAccents(UTF8Decode(self.Language)));
+    self.LanguageASCII := LowerCase(TransliterateToASCII(UTF8Decode(self.Language)));
   end
   else
     Log.LogError('File incomplete or not SingStar XML (A): ' + aFileName.ToNative);
@@ -1025,7 +1023,6 @@ function TSong.ReadTXTHeader(SongFile: TTextFileStream; ReadCustomTags: Boolean)
   EncFile: IPath; // encoded filename
   FullFileName: string;
   I, P: integer;
-  TransliterateResult: string;
 
   { adds a custom header tag to the song
     if there is no ':' in the read line, Tag should be empty
@@ -1112,17 +1109,15 @@ function TSong.ReadTXTHeader(SongFile: TTextFileStream; ReadCustomTags: Boolean)
       if (Identifier = 'TITLE') then
       begin
         self.Title := DecodeStringUTF8(Value, Encoding);
-        IConvert(self.Title, TransliterateResult, 'UTF-8', 'ASCII//TRANSLIT');
-        self.TitleNoAccent := LowerCase(TransliterateResult);
+        self.TitleASCII := LowerCase(TransliterateToASCII(self.Title));
         //Add Title Flag to Done
         Done := Done or 1;
       end
 
       else if (Identifier = 'ARTIST') then
       begin
         self.Artist := DecodeStringUTF8(Value, Encoding);
-        IConvert(self.Artist, TransliterateResult, 'UTF-8', 'ASCII//TRANSLIT');
-        self.ArtistNoAccent := LowerCase(TransliterateResult);
+        self.ArtistASCII := LowerCase(TransliterateToASCII(self.Artist));
 
         //Add Artist Flag to Done
         Done := Done or 2;
@@ -1204,28 +1199,28 @@ function TSong.ReadTXTHeader(SongFile: TTextFileStream; ReadCustomTags: Boolean)
       else if (Identifier = 'GENRE') then
       begin
         DecodeStringUTF8(Value, Genre, Encoding);
-        self.GenreNoAccent := LowerCase(GetStringWithNoAccents(Genre));
+        self.GenreASCII := LowerCase(TransliterateToASCII(Genre));
       end
 
       //Edition Sorting
       else if (Identifier = 'EDITION') then
       begin
         DecodeStringUTF8(Value, Edition, Encoding);
-        self.EditionNoAccent := LowerCase(GetStringWithNoAccents(Edition));
+        self.EditionASCII := LowerCase(TransliterateToASCII(Edition));
       end
 
       //Creator Tag
       else if (Identifier = 'CREATOR') then
       begin
         DecodeStringUTF8(Value, Creator, Encoding);
-        self.CreatorNoAccent := LowerCase(GetStringWithNoAccents(Creator));
+        self.CreatorASCII := LowerCase(TransliterateToASCII(Creator));
       end
 
       //Language Sorting
       else if (Identifier = 'LANGUAGE') then
       begin
         DecodeStringUTF8(Value, Language, Encoding);
-        self.LanguageNoAccent := LowerCase(GetStringWithNoAccents(Language));
+        self.LanguageASCII := LowerCase(TransliterateToASCII(Language));
       end
 
       //Year Sorting

src/base/USongs.pas

@@ -903,8 +903,7 @@ function TCatSongs.SetFilter(FilterStr: UTF8String; Filter: TSongFilter): cardin
   WordArray: array of UTF8String;
 begin
 
-  FilterStr := Trim(LowerCase(FilterStr));
-  FilterStr := GetStringWithNoAccents(FilterStr);
+  FilterStr := Trim(LowerCase(TransliterateToASCII(FilterStr)));
 
   if (FilterStr <> '') then
   begin
@@ -933,21 +932,21 @@ function TCatSongs.SetFilter(FilterStr: UTF8String; Filter: TSongFilter): cardin
       begin
         case Filter of
           fltAll:
-            TmpString := Song[I].ArtistNoAccent + ' ' + Song[i].TitleNoAccent + ' ' + Song[i].LanguageNoAccent + ' ' + Song[i].EditionNoAccent + ' ' + Song[i].GenreNoAccent + ' ' + IntToStr(Song[i].Year) + ' ' + Song[i].CreatorNoAccent; //+ ' ' + Song[i].Folder;
+            TmpString := Song[I].ArtistASCII + ' ' + Song[i].TitleASCII + ' ' + Song[i].LanguageASCII + ' ' + Song[i].EditionASCII + ' ' + Song[i].GenreASCII + ' ' + IntToStr(Song[i].Year) + ' ' + Song[i].CreatorASCII; //+ ' ' + Song[i].Folder;
           fltTitle:
-            TmpString := Song[I].TitleNoAccent;
+            TmpString := Song[I].TitleASCII;
           fltArtist:
-            TmpString := Song[I].ArtistNoAccent;
+            TmpString := Song[I].ArtistASCII;
           fltLanguage:
-            TmpString := Song[I].LanguageNoAccent;
+            TmpString := Song[I].LanguageASCII;
           fltEdition:
-            TmpString := Song[I].EditionNoAccent;
+            TmpString := Song[I].EditionASCII;
           fltGenre:
-            TmpString := Song[I].GenreNoAccent;
+            TmpString := Song[I].GenreASCII;
           fltYear:
             TmpString := IntToStr(Song[I].Year);
           fltCreator:
-            TmpString := Song[I].CreatorNoAccent;
+            TmpString := Song[I].CreatorASCII;
         end;
         Song[i].Visible := true;
         // Look for every searched word

src/base/UUnicodeUtils.pas

@@ -36,7 +36,8 @@ interface
   Windows,
 {$ENDIF}
   StrUtils,
-  SysUtils;
+  SysUtils,
+  iconvenc;
 
 type
   // String with unknown encoding. Introduced with Delphi 2009 and maybe soon
@@ -188,6 +189,11 @@ function WideStringLowerCase(ch: WideChar): WideString; overload;
 
 function WideStringReplaceChar(const text: WideString; search, rep: WideChar): WideString;
 
+(*
+ * Transliterates a UTF8 string to ASCII, by utilizing the GNU iconv utility
+ *)
+function TransliterateToASCII(const str: UTF8String) : string;
+
 implementation
 
 {$IFDEF UNIX}
@@ -675,6 +681,13 @@ function WideStringReplaceChar(const text: WideString; search, rep: WideChar): W
   end;
 end;
 
+function TransliterateToASCII(const str: UTF8String) : string;
+var
+  outbuffer: string;
+begin
+  IConvert(str, result, 'UTF-8', 'ASCII//TRANSLIT');
+end;
+
 initialization
   InitUnicodeUtils;
 

src/screens/UScreenJukebox.pas

@@ -538,12 +538,12 @@ procedure TScreenJukebox.FilterSongList(Filter: UTF8String);
 
   if (Filter <> '') then
   begin
-    Filter := GetStringWithNoAccents(UTF8Decode(UTF8LowerCase(Filter)));
+    Filter := LowerCase(TransliterateToASCII(UTF8Decode(Filter)));
 
     SetLength(JukeboxVisibleSongs, 0);
     for I := 0 to High(JukeboxSongsList) do
     begin
-      SongD := CatSongs.Song[JukeboxSongsList[I]].ArtistNoAccent + ' - ' + CatSongs.Song[JukeboxSongsList[I]].TitleNoAccent;
+      SongD := CatSongs.Song[JukeboxSongsList[I]].ArtistASCII + ' - ' + CatSongs.Song[JukeboxSongsList[I]].TitleASCII;
 
       if (UTF8ContainsStr(SongD, Filter)) then
       begin