Jukebox codeformat #783
Merged
Jukebox codeformat #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbeque-squared
force-pushed
the
jukebox-codeformat
branch
from
6f900ba
to
e1c5292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while working on #782 my editor was going a bit haywire and showing pretty much the entire jukebox file as comment. It appears to be caused by there being a comment start
{at both line 473 and 497, but only 1 close}at line 528. This PR removes the one at line 497 because it doesn't appear to be doing anything.The second commit then adds a TODO above the function because I'm pretty sure this is doing absolutely nothing and we should just get rid of it + refactor whatever currently calls this function.