Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zsync #933

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

DeinAlptraum
Copy link
Contributor

@DeinAlptraum DeinAlptraum commented Dec 31, 2024

I didn't see zsync actually being used anywhere, so attempt to build without it.

See #931

@DeinAlptraum
Copy link
Contributor Author

Built without a problem and runs just fine on my end.
@s09bQ5 since you were the last one to touch this, do you know if/why we include zsync?

@s09bQ5
Copy link
Collaborator

s09bQ5 commented Jan 1, 2025

Built without a problem and runs just fine on my end. @s09bQ5 since you were the last one to touch this, do you know if/why we include zsync?

We include it because of

2024-12-31T14:11:06.1259383Z appimagetool, continuous build (commit 8bbf694), build <local dev build> built on 2024-12-31 14:02:19 UTC
2024-12-31T14:11:06.1262064Z WARNING: zsyncmake command is missing, please install it if you want to use binary delta updates

But it's just a warning and we don't do binary delta updates.

@barbeque-squared
Copy link
Member

I had a quick look at the appimagetool repo, doesn't appear to be any way to suppress the warning. It looks to be called from a Makefile, it might be useful to have an echo right before that command that any warning about binary delta updates can be ignored because we don't use them? Has the bonus of touching the Makefile in this PR too.

@DeinAlptraum
Copy link
Contributor Author

might be useful to have an echo right before that command

Added this

@DeinAlptraum DeinAlptraum changed the title [WIP] Remove zsync Remove zsync Jan 2, 2025
@barbeque-squared barbeque-squared merged commit aea2312 into UltraStar-Deluxe:master Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants