Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I submitted the Chinese version of the manual #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kokdemo
Copy link

@kokdemo kokdemo commented Mar 26, 2024

cover almost post in the manual

What does this PR do and why is it necessary?
There are a lot of users in China who need a manual to learn

How was it tested? How can it be tested by the reviewer?

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

cover almost post in the manual
Copy link
Contributor

@Bra-Ger Bra-Ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found only a few minor issues which are caused by the retranslation into English. Please check if the translation in the Chinese version are correct.

"description": "The title of the footer links column with title=Rechtliches in the footer"
},
"link.item.label.Mitwirkende": {
"message": "贡献者",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation sounds strange in English but might be correct in Chinese


![复制和粘贴](https://raw.githubusercontent.com/Ultraschall/ultraschall-manual/main/assets/images/Schnitt/copy-and-cut.png) _上下文菜单提供了各种复制和剪切模式。_

### 双端录音
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retranslation into English is strange "Dual-Ended Recording" but the translation might be OK.

Copy link
Member

@nucleus-ffm nucleus-ffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but some translations sound strange

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet fully translated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet fully translated

@@ -0,0 +1,34 @@
{
"version.label": {
"message": "Next",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translation

"description": "The label for the doc item Über in sidebar tutorialSidebar, linking to the doc about"
},
"sidebar.tutorialSidebar.doc.Mitwirkende": {
"message": "贡献者",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation says "benefactor" - is that the right translation for "contributor"?

@nucleus-ffm
Copy link
Member

Thank you for your work. We really appreciate your pull request. We have tried to review it (with a translation of course) and have noticed some strange translations. You may want to take a look at our comments and confirm that this is the correct translation. There are also some minor translations missing.

There will also soon be the 5.1 release of Ultraschall with some minor updates to the manual prepare 5.1. We will merge the branch soon. It would be great if you could also update your translation then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants