#35 add request url to stub #43
Conversation
http_stubs/templatetags/utils.py
Outdated
|
|
||
| @register.simple_tag(takes_context=True, name='absolute') | ||
| def get_absolute_url_tag(context, url): | ||
| """Тег возвращающий абсолютный урл.""" |
There was a problem hiding this comment.
Could you please write the docstring in English?
There was a problem hiding this comment.
Sorry for my Russian;) It's just a habit.
Corrected.
Codecov Report
@@ Coverage Diff @@
## develop #43 +/- ##
===========================================
+ Coverage 98.21% 98.31% +0.10%
===========================================
Files 4 5 +1
Lines 112 119 +7
Branches 4 4
===========================================
+ Hits 110 117 +7
Misses 2 2
Continue to review full report at Codecov.
|
| @@ -0,0 +1,7 @@ | |||
| {% extends "admin/change_form.html" %} | |||
| {% load i18n admin_urls static admin_modify simpletags%} | |||
There was a problem hiding this comment.
| {% load i18n admin_urls static admin_modify simpletags%} |
Здесь не используется ни один тег (кроме доступных по умолчанию).
| {{ field.field }} | ||
| {# added request url for path field(issue #35) #} | ||
| {% if field.field.name == 'path' %}<div class="readonly"><div id="full-path">{% absolute field.field.value %}</div><div id="path-copied-alert">Скопировано!</div></div>{% endif %} | ||
| {# #} |
There was a problem hiding this comment.
BTW, I've missed Russian word 'Скопировано!' here. :) Probably should be in English or use i18n for translation.
There was a problem hiding this comment.
Meeh... I has created a new issue for it #50
…added test and linted
|
Kudos, SonarCloud Quality Gate passed!
|
closes #35