#47 empty headers in admin

http_stubs/tests/tests.py

@@ -9,6 +9,8 @@
 class TestHTTPStubView:
     """Tests representation of the http stubs."""
 
+    path = '/default_path/'
+
     @pytest.mark.parametrize('method', HTTPMethod.names())
     def test_nonexistent_stub(self, method: str, client):
         """Tests response when stub is not found.
@@ -33,7 +35,7 @@ def test_exist_not_regexp_stub(
         :param client: http client fixture
         """
         http_stub_factory(method=method)
-        response = getattr(client, method.lower())('/default_path/')
+        response = getattr(client, method.lower())(self.path)
 
         if method != HTTPMethod.HEAD.name:
             assert response.content == b'[]'
@@ -49,7 +51,7 @@ def test_write_log(self, http_stub_factory, client):
         """
         content_type = 'text/plain'
         http_body = http_stub_factory(method=HTTPMethod.POST.name)
-        client.post('/default_path/', 'test', content_type=content_type)
+        client.post(self.path, 'test', content_type=content_type)
         log = LogEntry.objects.last()
 
         def _datefmt(date) -> str:  # noqa:WPS430
@@ -67,13 +69,23 @@ def _datefmt(date) -> str:  # noqa:WPS430
         assert log.headers == {
             'Content-Length': '4',
             'Content-Type': content_type,
-            'Cookie': '',
         }
         assert log.body == 'test'
         assert log.http_stub == http_body
         assert log.method == HTTPMethod.POST.name
         assert log.path == 'http://testserver/default_path/'
 
+    def test_write_log_without_empty_headers(self, http_stub_factory, client):
+        """Tests request logging without empty headers.
+
+        :param http_stub_factory: HTTPStub factory
+        :param client: http client fixture
+        """
+        http_stub_factory(method=HTTPMethod.GET.name)
+        client.get(self.path)
+        log = LogEntry.objects.last()
+        assert bool(log.headers) is False
+
     @pytest.mark.parametrize('method', HTTPMethod.names())
     def test_exist_regexp_stub(self, method: str, http_stub_factory, client):
         """Tests response for the regex stub.

http_stubs/views.py

@@ -1,5 +1,5 @@
 from time import sleep
-from typing import Optional
+from typing import Dict, Optional
 
 from django.http import HttpRequest, HttpResponse, HttpResponseNotFound
 from django.views import View
@@ -52,7 +52,7 @@ def dispatch(self, request: HttpRequest, *args, **kwargs) -> HttpResponse:
             method=request.method,
             source_ip=request.META['REMOTE_ADDR'],
             body=request.body.decode('utf-8'),
-            headers=dict(request.headers),
+            headers=self.remove_empty_headers(request.headers),
             http_stub=stub,
         )
         sleep(stub.resp_delay / 1000)
@@ -64,3 +64,14 @@ def dispatch(self, request: HttpRequest, *args, **kwargs) -> HttpResponse:
         for header_name, header_value in stub.resp_headers.items():
             response[header_name] = header_value
         return response
+
+    def remove_empty_headers(self, headers: Dict[str, str]) -> Dict[str, str]:
+        """Remove empty headers.
+
+        :param headers: dictionary of headers
+        :returns: dictionary without empty headers
+        """
+        return {
+            header: header_value
+            for header, header_value in headers.items() if header_value != ''
+        }