Harleyg321 feature/temp control #523
Conversation
…OctoDash into harleyg321-feature/temp_control
| margin: 0 auto; | ||
| border: solid 0.6vw; | ||
| border-radius: 3vw; | ||
| margin-top: 5vh; |
There was a problem hiding this comment.
| margin-top: 5vh; |
Part of the changes you've made seem to have moved the controller box down the screen, removing the top margin gets it back to the center again.
There was a problem hiding this comment.
Ah, it was moving the image inside the table that did it.
If you keep the image inside the table, I suggest making this change. If you move the image outside the table as in my other review comment, then this change should not be made.
| [matRippleUnbounded]="false" />back</td> | ||
| <img [src]="'assets/' + (view === QuickControlView.HOTEND ? 'nozzle.svg' : view === QuickControlView.HEATBED ? 'heat-bed.svg' : 'fan.svg')" | ||
| class="quick-control__center-icon-small"> | ||
| </tr> | ||
| </table> | ||
| <div class="quick-control__controller"> |
There was a problem hiding this comment.
| <td class="top-bar__back"><img src="assets/back.svg" class="top-bar__back-icon" matRipple | |
| [matRippleUnbounded]="false" />back</td> | |
| <img [src]="'assets/' + (view === QuickControlView.HOTEND ? 'nozzle.svg' : view === QuickControlView.HEATBED ? 'heat-bed.svg' : 'fan.svg')" | |
| class="quick-control__center-icon-small"> | |
| </tr> | |
| </table> | |
| <div class="quick-control__controller"> | |
| <td class="top-bar__back"><img src="assets/back.svg" class="top-bar__back-icon" matRipple | |
| [matRippleUnbounded]="false" />back</td> | |
| </tr> | |
| </table> | |
| <img [src]="'assets/' + (view === QuickControlView.HOTEND ? 'nozzle.svg' : view === QuickControlView.HEATBED ? 'heat-bed.svg' : 'fan.svg')" | |
| class="quick-control__center-icon-small"> | |
| <div class="quick-control__controller"> |
Currently the icon doesn't display. Moving rows 34/35 down 2 rows so the image is outside the table fixes the issue.
Alternatively, changing the class to top-bar__center-icon and keeping it where it is inside the table row gets it to display although it then isn't centered.
|
Somehow messed it up with the icon. I moved it into the table and everything is working for me now :) Will be released in 1.4.1 (should be in the next couple of days). And once again: Closes #259 |
No description provided.