Attempt fixes to reported erring scripts #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
reviewed
Oct 5, 2022
| else if (GameName.Contains("survey_program")) | ||
| deltamode = true; | ||
| else | ||
| deltamode = ScriptQuestion("Is this Deltarune Chapter 1 or a mod thereof?") ? true : false; |
There was a problem hiding this comment.
ScriptQuestion already returns a bool, why do a ? true : false after it?
There was a problem hiding this comment.
Somehow I was unsure it was a bool, but was sure it could be used in a ternary. In retrospect, of course it's a bool. I'll fix that.
Miepee
reviewed
Oct 19, 2022
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| EnsureDataLoaded(); | |||
|
|
|||
| // Is actually incompatible. Something broke when I (Space Core) tried to combine the UT and SURVEY_PROGRAM code. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove Chapter 2 errors from DeltaMILK, fix other errors on DeltaHATE caused by changing variable names. Make it handle games that aren't named "UNDERTALE" a bit more gracefully, too.
Caveats
DeltaHATE still doesn't work on Chapter 2.
Notes
N/A