Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs content state saving and restoring (tab sessions). #1152

Merged
merged 22 commits into from
Mar 23, 2023

Conversation

VladiStep
Copy link
Member

@VladiStep VladiStep commented Jan 10, 2023

Description

  1. All tabs preserve their content state.
    For example, code editor tab preserves both "Decompiled" and "Disassembled" caret position and line, and the selected tab itself.
    Closes Add tabs sessions. #1115, closes Save scroll position for each tab. #1020, closes The root scroll viewer of data editors always receives scroll event. #1154, closes The root scroll viewer doesn't reset the position on opening of different object. #1155
  2. Tab class declaration is moved out to a separate file - this gives the most of the code change line count.
  3. Everything in the Tab.cs file is documented.
  4. Room editor preview resets scroll position and scale on opening of different room.
  5. Closes Object ID label doesn't update on tab closing. #1129, closes "SearchASM.csx" should always open "Disassembly" tab. #1156, closes Code editor freezes the app on opening of "Disassembly". #1157

Here are all code changes skipping the first commit (which only moved all tab code into a separate file).

Caveats

There are decent amount of code changes, so there could be some bugs (and probably crashes) I didn't notice.

Notes

This PR includes the changes of #1148.

1) Code editor preserves caret position after compiling, between "Decompiled" and "Disassembled" tabs, and between the tabs.
2) The changes from the PR UnderminersTeam#1148.
3) A little performance improvement of "NameGenerator" and "NumberGenerator" (code editor instance is declared on class init).
@github-actions
Copy link

github-actions bot commented Jan 10, 2023

@VladiStep VladiStep marked this pull request as ready for review January 16, 2023 21:42
@Grossley Grossley merged commit 5355cf6 into UnderminersTeam:master Mar 23, 2023
@VladiStep VladiStep deleted the tabsState branch March 23, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment