-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs content state saving and restoring (tab sessions). #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… related classes.
1) Code editor preserves caret position after compiling, between "Decompiled" and "Disassembled" tabs, and between the tabs. 2) The changes from the PR UnderminersTeam#1148. 3) A little performance improvement of "NameGenerator" and "NumberGenerator" (code editor instance is declared on class init).
Download the artifacts for this pull request here: GUI:
CLI: |
… delay on tab switching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For example, code editor tab preserves both "Decompiled" and "Disassembled" caret position and line, and the selected tab itself.
Closes Add tabs sessions. #1115, closes Save scroll position for each tab. #1020, closes The root scroll viewer of data editors always receives scroll event. #1154, closes The root scroll viewer doesn't reset the position on opening of different object. #1155
Tab
class declaration is moved out to a separate file - this gives the most of the code change line count.Here are all code changes skipping the first commit (which only moved all tab code into a separate file).
Caveats
There are decent amount of code changes, so there could be some bugs (and probably crashes) I didn't notice.
Notes
This PR includes the changes of #1148.