Fix returns/multiple scripts in GMS2.3+ #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heavily optimizable most likely
It might be more readable to condense all of these checks into however many nested ifs resulting in a boolean. "dontProduceStatement" or somesuch
|
Download the artifacts for this pull request here: GUI:
CLI: |
VladiStep
reviewed
Feb 27, 2023
Co-authored-by: VladiStep <vlad2001.21@mail.ru>
Jacky720
changed the title
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GMS 2.3 scripts always produce an
exitinstruction, even for scripts lacking areturn. UTMT previously interpreted this as a return anyway, and the workaround of ignoring returns on the top level block caused issue #900. (This closes #900).Commit 60ea473 additionally adds support for changing the offset, length, and argument counts of anonymous script entries, and creating new ones by simply invoking
function, during script compilation.Caveats
The new workaround takes the list of blocks and
Sort()s its keys to peek at the next and identify the extraneousexits. This may result in performance degradation for complex scripts with many blocks and many returns.Notes
N/A