Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ShowRoomName.csx to Work With Deltarune chapter 2. #1481

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

EvaxTheFox
Copy link
Contributor

@EvaxTheFox EvaxTheFox commented Sep 15, 2023

Description

The ShowRoomName script doesnt really work with deltarune. i have made it possible.
###Notes

Feel free to edit this (by maintainers)

// Adds room ID and name display under the debug mode timer display

EnsureDataLoaded();

ScriptMessage("Show room name and ID in debug mode\nby krzys_h, Kneesnap\n\n\nDeltarune Ch2 Patch By GattoDev");

This comment was marked as resolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nevermind, I see now that the message was there, and you just added yourself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was stupid and remoce that i believe so

@EvaxTheFox EvaxTheFox closed this Sep 15, 2023
@EvaxTheFox
Copy link
Contributor Author

i will close this Pull request and try to make another hot piece of garbage next time

@EvaxTheFox
Copy link
Contributor Author

nevermind

@EvaxTheFox EvaxTheFox reopened this Sep 15, 2023
@VladiStep
Copy link
Member

No, your PR seems fine, I think you only need to move that one line under the if block

@EvaxTheFox
Copy link
Contributor Author

No, your PR seems fine, I think you only need to move that one line under the if block

its just so it doesnt get the naming wrong

@EvaxTheFox
Copy link
Contributor Author

checked and yes it does work with Undertale too so thats a win. hope me get accepte

@Miepee
Copy link
Contributor

Miepee commented Feb 19, 2024

@EvaxTheFox any updates on the reviews?

Copy link

github-actions bot commented Jun 2, 2024

Copy link
Member

@colinator27 colinator27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be changed back to use global.debug for Undertale again

@Miepee Miepee requested a review from colinator27 July 1, 2024 13:08
Copy link
Member

@colinator27 colinator27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and this seems to work!

@colinator27
Copy link
Member

Going to expedite getting this merged in, given this is a small script and I've now tested it.

@colinator27 colinator27 merged commit 83ff2fc into UnderminersTeam:master Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants