-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ShowRoomName.csx to Work With Deltarune chapter 2. #1481
Conversation
only tested on deltarune.
// Adds room ID and name display under the debug mode timer display | ||
|
||
EnsureDataLoaded(); | ||
|
||
ScriptMessage("Show room name and ID in debug mode\nby krzys_h, Kneesnap\n\n\nDeltarune Ch2 Patch By GattoDev"); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, nevermind, I see now that the message was there, and you just added yourself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was stupid and remoce that i believe so
i will close this Pull request and try to make another hot piece of garbage next time |
nevermind |
No, your PR seems fine, I think you only need to move that one line under the |
its just so it doesnt get the naming wrong |
checked and yes it does work with Undertale too so thats a win. hope me get accepte |
@EvaxTheFox any updates on the reviews? |
Download the artifacts for this pull request here: GUI:
CLI: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be changed back to use global.debug
for Undertale again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, and this seems to work!
Going to expedite getting this merged in, given this is a small script and I've now tested it. |
Description
The ShowRoomName script doesnt really work with deltarune. i have made it possible.
###Notes
Feel free to edit this (by maintainers)