Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UA: Add rough check for CodeLocals' removal from FUNC in 2024.8 #1937

Draft
wants to merge 11 commits into
base: underanalyzer
Choose a base branch
from

Conversation

Dobby233Liu
Copy link
Contributor

@Dobby233Liu Dobby233Liu commented Oct 4, 2024

Description

As @colinator27 noted around the time of GM 2024.8(00) Beta's release, this GM version removes the CodeLocals list from the FUNC chunk. This PR adds logic to detect this, and makes builtin scripts aware of this.

Might fix #1928.

For contributors: feel free to continue this yourself if it's stuck in limbo or something.

Caveats

  • HEAVILY UNTESTED, the disassembler didn't get touched a lot. I only checked whether (de)serialization works as expected.
  • Variable names are no longer highlighted in the code editor.

Notes

Data.CodeLocals is now null if the bytecode version doesn't support it, it must be created manually if needed.

Copy link

github-actions bot commented Oct 4, 2024

@Dobby233Liu Dobby233Liu marked this pull request as ready for review October 4, 2024 14:49
@Dobby233Liu
Copy link
Contributor Author

Doesn't look too wrong so bug catching can take place. No clue what to do with the disassembler's message

@Dobby233Liu
Copy link
Contributor Author

Dobby233Liu commented Oct 4, 2024

Amazing UX GitHub, I'm trying again. Might fix #1928.
Incomprehensible

@JeodC
Copy link

JeodC commented Oct 6, 2024

I am unable to use the search function when using this artifact fyi, but it does load 2024.8 data for reading and some editing. It seems to have a chance to somehow corrupt gml scripts, from time to time when I make a modification and leave a script, I'll try to come back to it and get that giant wall of greentext.

@LukeWarnut
Copy link

Can confirm that it does fix #1928

@JeodC
Copy link

JeodC commented Nov 27, 2024

NewTextureRepacker.zip

I modified the NewTextureRepacker script to be a form instead of a messagebox. This is useful since it contains user configurable items that the user may wish to change on a per-game basis. The reuse extracted items checkbox does not work atm. Feel free to implement it and adjust.

image

@Dobby233Liu Dobby233Liu force-pushed the ua-code-locals-removal-handling-1 branch 2 times, most recently from d8eca5e to 8080c33 Compare December 13, 2024 11:23
Co-authored-by: zivmaor <63353113+zivmaor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants