Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beautifier-tslint to Unibeautify VSCode extension #11

Open
muuvmuuv opened this issue Oct 7, 2018 · 7 comments
Open

Add beautifier-tslint to Unibeautify VSCode extension #11

muuvmuuv opened this issue Oct 7, 2018 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@muuvmuuv
Copy link

muuvmuuv commented Oct 7, 2018

Seeing this in the console: Beautifier not found: TSLint: Error: Beautifier not found: TSLint TSLint is globally and locally installed. Guess the VS Code extensions just has it not added as dependency

@stevenzeck
Copy link
Contributor

stevenzeck commented Oct 8, 2018

Nope it hasn't been added to VSCode yet: https://github.com/Unibeautify/vscode/blob/master/src/beautifiers.ts. I've struggled getting this beautifier to work since it requires some pretty specific arguments to be passed, that's why it doesn't have much done.

@muuvmuuv
Copy link
Author

muuvmuuv commented Oct 8, 2018

@stevenzeck Ah alright, any plan when you will add it?

@stevenzeck
Copy link
Contributor

I don't plan on adding it to VSCode at this time and don't have time to work on it now. PR's are welcome.

@muuvmuuv
Copy link
Author

muuvmuuv commented Oct 9, 2018

I'll have a look, but planned to work on the stylelint beautifier

@muuvmuuv
Copy link
Author

muuvmuuv commented Oct 9, 2018

@stevenzeck what are the things you think are not working? It seems pretty stable to me. Tested with extends and rulesDirectory. It also seems to pass prefer_beautifier_config correctly.

@Glavin001 Glavin001 changed the title VS Code error Add beautifier-tslint to Unibeautify VSCode extension Oct 10, 2018
@Glavin001 Glavin001 added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 10, 2018
@jonyeezs
Copy link

jonyeezs commented Feb 6, 2019

@stevenzeck

it requires some pretty specific arguments to be passe

Could you help give more info on this for those who might want to resolve this issue?

And what's the progress on this? or if @muuvmuuv do you have a workaround?
I'm assuming because VScode has tslint inbuilt?

jonyeezs added a commit to jonyeezs/extract-module-exports that referenced this issue Feb 6, 2019
@stevenzeck
Copy link
Contributor

stevenzeck commented Feb 6, 2019

@muuvmuuv it works fine if using TSLint config file. I'm referring to transforming options from unibeautify to TSLint.

@jonyeezs https://github.com/Unibeautify/beautifier-tslint/blob/master/src/options.ts#L16-L28 is an example, specifically line 22 where I have single line and multiline always. The rules in TSLint that need to be transformed can get complicated from what I remember when I started working in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants