Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for CI pipeline #2218

Merged
merged 5 commits into from
Nov 25, 2021
Merged

Conversation

dopplershift
Copy link
Member

@dopplershift dopplershift commented Nov 24, 2021

Description Of Changes

  1. Fix linkchecker for nightly builds
    We were always filtering based on the (assumed) current merge. Instead, just pass true/false based on whether the build is a PR, and find the appropriate commits within the script.

  2. Update action version numbers
    Replace explicit versions for actions with only major where possible. This will hopefully reduce dependabot churn (assuming it supports this--unclear but has seemed to be working for us), and also compensates for the fact that dependabot is not issuing updates for actions versions within our own composite actions. This also updates the install-pypi action to use a version of setup-python that supports caching.

  3. Add concurrency setting which uses concurrency groups to cancel existing builds (pending and running) on a PR when new commits are pushed.

Checklist

- [ ] Closes #xxxx
- [ ] Tests added
- [ ] Fully documented

We were always filtering based on the (assumed) current merge. Instead,
just pass true/false based on whether the build is a PR, and find the
appropriate commits within the script.
@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should labels Nov 24, 2021
@dopplershift dopplershift requested a review from a team as a code owner November 24, 2021 23:08
@dopplershift dopplershift requested review from dcamron and removed request for a team November 24, 2021 23:08
Where possible. This will hopefully reduce dependabot churn (assuming it
supports this--unclear), and also compensates for the fact that
dependabot is not issuing updates for actions versions within our own
composite actions.
@dopplershift dopplershift changed the title Fix linkchecker for nightly builds Fixes for CI pipeline Nov 24, 2021
When using yaml concatenation | don't also make an explicit list.
This should set things up to automatically cancel a run once a new one
is pushed to a PR.
@dopplershift dopplershift force-pushed the nightly-linkchecker branch 2 times, most recently from 20ae42b to f6f872c Compare November 25, 2021 00:53
@dopplershift dopplershift changed the title Fixes for CI pipeline Updates for CI pipeline Nov 25, 2021
This should eliminate false failures from CodeCov before all the jobs
finish. Currently set to make sure we should get builds across all the
OSes and all Pythons.
@dopplershift dopplershift merged commit b6b5a14 into Unidata:main Nov 25, 2021
@dopplershift dopplershift deleted the nightly-linkchecker branch November 25, 2021 01:43
@github-actions github-actions bot added this to the 1.2.0 milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant