Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few doc fixes #2971

Merged
merged 2 commits into from
Mar 30, 2023
Merged

A few doc fixes #2971

merged 2 commits into from
Mar 30, 2023

Conversation

dopplershift
Copy link
Member

Description Of Changes

Checklist

@dopplershift
DOC: Fix typo in point interpolation example (Fixes Unidata#2970)
68b489f 
Seems to have been there since the beginning.
@dopplershift
DOC: Improve mean_pressure_weighted docstring
0ffb097 
Add the formula and also explicitly note the default depth value. Also
clean up the docstring for weighted_continuous_average a bit, too.
@dopplershift dopplershift added Type: Bug Something is not working like it should Area: Docs Affects documentation Type: Enhancement Enhancement to existing functionality labels Mar 28, 2023
@dopplershift dopplershift added this to the April 2023 milestone Mar 28, 2023
@dopplershift dopplershift requested a review from a team as a code owner March 28, 2023 20:37
@dopplershift dopplershift requested review from dcamron and removed request for a team March 28, 2023 20:37
dcamron
dcamron approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not sure if there's more we should do about clarifying the "depth defines p_s" behavior here and now. I guess I'd save that until we heard more headache first.

@dopplershift
Copy link
Member Author

Yeah, unless there are some immediate thoughts on improvement, I'd leave that TBD. "Perfect enemy of the good" and all that...

@dcamron dcamron merged commit dfe8db6 into Unidata:main Mar 30, 2023
@dopplershift dopplershift deleted the doc-fixes branch March 30, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcamron dcamron dcamron approved these changes

Assignees
No one assigned
Labels
Area: Docs Affects documentation Type: Bug Something is not working like it should Type: Enhancement Enhancement to existing functionality
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dopplershift @dcamron