-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate scanner from parser. #67 #74
Open
schwehr
wants to merge
6
commits into
Unidata:main
Choose a base branch
from
schwehr:scanner-parser-separation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schwehr
commented
Aug 10, 2018
•
edited
Loading
edited
- flex and bison now generate scanner.h and parser.h respectively
- _restartScanner and _isTime are no longer static
- Added utGetYyCBufP() to pass yy_c_buf_p
- #if'ed out ut_add_name_prefix in prefix as there are two header definitions
This is in preparation for removing the include of scanner.c from parser.c for Unidata#67
- flex and bison now generate scanner.h and parser.h respectively - _restartScanner and _isTime are no longer static - Added utGetYyCBufP() to pass yy_c_buf_p - #if'ed out ut_add_name_prefix in prefix as there are two header definitions
Sigh... Travis-CI isn't being particularly helpful at the moment.
|
Next up is to log the flex and bison versions. |
Oh... autoconf and configure. I've been doing
|
I will do a separate pull request to add checking the cmake build. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.