MAINT: Build wheels against NumPy 2.0 #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
larsoner
commented
Apr 22, 2024
| @@ -46,6 +46,7 @@ jobs: | |||
| python -c "import cftime; print(f'cftime v{cftime.__version__}')" && | |||
| python -m pip install check-manifest cython pytest pytest-cov && | |||
| python -m pytest -vv {package}/test | |||
| CIBW_BUILD_FRONTEND: 'pip; args: --pre --extra-index-url "https://pypi.anaconda.org/scientific-python-nightly-wheels/simple"' | |||
There was a problem hiding this comment.
This part (or something like it) is necessary if you want to release before 2.0 actually lands
There was a problem hiding this comment.
There was a problem hiding this comment.
Ohhh yes you're right I forgot it's on PyPI proper now 🤦
There was a problem hiding this comment.
Thank you for being proactive and for helping with this. I am also looking forward to a numpy 2 compatible release. Just trying to save you time.
|
Closing since it seems like this won't be useful given the release plan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening just for completeness in case 2.0-compatible wheels want to be cut before 2.0 actually comes out. Probably no point in merging if new wheels won't be released before NumPy 2.0.0 is released. So feel free to close!
Related to #325