Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow in nc_test4/tst_fill_attr_vanish.c #2027

Closed
WardF opened this issue Jul 6, 2021 · 0 comments · Fixed by #2028
Closed

Stack overflow in nc_test4/tst_fill_attr_vanish.c #2027

WardF opened this issue Jul 6, 2021 · 0 comments · Fixed by #2028

Comments

@WardF
Copy link
Member

WardF commented Jul 6, 2021

Stack overflow reported by valgrind (and address/memory sanitization) in nc_test4/tst_fill_attr_vanish.c, traced back to non-null-terminated-strings being used.

WardF added a commit that referenced this issue Jul 6, 2021
WardF added a commit that referenced this issue Jul 6, 2021
clrpackages pushed a commit to clearlinux-pkgs/netcdf that referenced this issue Aug 31, 2021
Ben Boeckel (3):
      ncexhash: replace invalid UTF-8 sequence
      dinfermodel: don't fail if NC_NETCDF4 is allowed, but NC3 is found
      hdf5: try and fill in HDF5_C_LIBRARY from HDF5_hdf5_LIBRARY if possible

Bruno Pagani (1):
      libhdf5/H5FDhttp: add missing semicolons to H5Epush_ret

Dennis Heimbigner (85):
      Add support for the XArray Zarr _ARRAY_DIMENSIONS attribute
      Update RELEASE NOTES
      Update actions
      Regularize the scoping of types
      Update RELEASE_NOTES
      fix cmake error
      Update the bzip library in plugins to version 1.0.8
      ckp
      Addendum: This PR has been extended to include
      force tests to rerun
      update actions
      ckp
      ckp
      actions
      Fix the handling of certain alias types on CDL files.
      Update release notes
      try18
      Fix ncdump bug when printing VLENs with basetype char
      Add test case
      Update release notes
      fix CMake error
      Fix shell handling of escapes
      Update RELEASENOTES
      Upgrade the nczarr code to match Zarr V2
      Update RELEASE NOTES
      reset action signals
      try 1: fix test properties
      try 2: fix test properties
      LGTM cleanup
      logdepend
      Allow .rc tests to work in parallel by isolation
      remove push signal
      Fix JSON quoted string processing in libnczarr
      Update RELEASE_NOTES
      Regularize the semantics of mkstemp.
      Update RELEASE_NOTES.md
      reset action triggers
      Improve error message when non-existent filter is encountered.
      Update RELEASE NOTES
      Fix NCclosedir in dpathmgr.c
      Update RELEASENOTES
      add extra test
      Fix counting of dimensions in ncdump
      Update Release Notes
      turn off tracing
      fix cygwin build
      Fix 2 for cygwin build
      More cygwin fixes
      Improve operation of the DAP4 code and fix bugs
      Update release notes
      Fix Mingw versus XGetopt (again)
      Update Release notes
      szip
      charvlen
      update file permission
      pathcvt
      pathcvtadd
      converted
      final
      sigh
      Re-enable DAP2 authorization tests
      Update RELEASE NOTES
      Add backslash escape option to pathcvt and test
      Regularize the scoping of dimensions
      Update Release Notes
      Revert action triggers
      NCZarr is outputting fill value as an array instead of a singleton.
      Update release notes
      Move to Version 2 NCZarr Extended Meta-Data
      Update RELEASE_NOTES
      Bad file reference
      undebug
      remove push
      Fix bad chunkpath calculation
      Fix chunk key when using dimension_separator
      Update RELEASE_NOTES
      Add missing files so --enable-benchmarks works again.
      Support Windows network paths: \\svc\x\y...
      Update release notes
      Fix a number of bugs in the nczarr code.
      update release notes
      Add test cases
      de-push
      Fix library crash
      Turn off bad test

Edward Hartnett (11):
      improved program nc_perf/tst_gfs_data_1.c
      fixed warning in tst_h_files4.c
      fixing H5Linterate() API compatipility problem
      remove nc_perf/tst_mem1 from tests run
      remove nc_perf/tst_mem1 from tests run
      made nc_perf not build and run benchmarks in parallel
      turned of tst_gfs_data_1.c benchmark for HDF5 less than 1.10.2
      added H5public.h to includes
      disable dap remote tests by default
      enable dap remote tests by default
      turned off running of run_knmi_bm.sh benchmark with make check

Egbert Eich (1):
      check: Include testpathcvt.sh only if test is built

Greg Sjaardema (14):
      Fix some HDF5-related tests
      Fix use of ininitialized CMake variable
      Remove need for HDF5-1.6 API being defined
      Fix so works with hdf5-1.8 also
      Fix for use with szip and also 1.8.21
      Simply version check logic
      Clean up curl symbol tests
      Remove a debug print
      Remove a debug print
      The coord dimids should be written for all variables
      Only write the coord dimids if ndims >= 1
      Make variable easier to compress
      Disable varible rename test
      Add a comment

Orion Poplawski (2):
      Fix out of tree builds with configure - add $(top_builddir)/include to include directory search
      Fix tst_h_atts3 for hdf5 1.12

Philippe Antoine (1):
      Adds fuzz target for oss-fuzz integration

Tobias Kölling (9):
      added test for reading virtual datasets
      tst_virtual_datasets: add missing hdf5 close calls
      hdf5: added unknown storage specification
      changed H5Pset_fclose_degree to H5F_CLOSE_WEAK
      change H5F_CLOSE_SEMI -> H5F_CLOSE_WEAK for nc4_create_file as well
      ange H5F_CLOSE_SEMI -> H5F_CLOSE_WEAK for netcdf related tests
      added NC_VIRTUAL storage layout
      check if H5D_VIRTUAL exists in installed HDF5 library
      enable test for virtual datasets only for HDF5 >= 1.10.0

Ward Fisher (40):
      Refactored the HDF5 version detection logic in CMakeLists.txt in support of Unidata/netcdf-c#1962
      Corrected a typo.
      Updated release notes, made if-block syntax more verbose.
      Updated release notes.
      Addressing some uninitialized variables to see if there is an effect on compiler optimizations.  Good practice to have these fixed in any event.
      Clean up a leftover directory.
      Updated Release Notes.
      Updated github actions to add make distcheck
      Added DISTCHECK_CONFIGURE_FLAGS to Github Actions distcheck stanza.
      Trying to fix a confounding error in make distcheck.
      Speculating on fix, perhaps a race issue on make distcheck when passed the command to use concurrent processes.
      Temporarily add an ssh-interface when make distcheck fails.
      Testing a different theory
      Revert previous change.
      Temporarily remove distcheck from Github Actions
      Clean up stray file that was fouling make distcheck
      Added missing file.
      Added a temporary fix in support of Unidata/netcdf-c#2018.  Also, fixed a missing reference file when using cmake-based build systems.
      Turn verbose output on in nc_test.
      Fix in support of Unidata/netcdf-c#2027
      Added explicit initialization to address some potential issues raised by clang static analysis.
      Eliminate a lot of 'result of operation is undefined or garbage' errors reported by static analysis.  These errors appeared to be false positives as there was logic that should prevent their occurance, but it's possible that optimization would result in these error states occuring.
      Fix an accidentally-introduced bug.
      Added -fno-strict-aliasing to CFLAGS when the compiler supports it and autotools are in use.
      Added -fno-strict-aliasing to CFLAGS when the compiler supports it and cmake is in use.
      Clean up orphaned file entry causing a failure in 'make distcheck'
      Updated SO Version in line with https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
      Bump version numbers for the next development cycle.
      Revert versions to current release, 4.8.1
      Update the source url for windows installer downloads to reflect the move tot he new artifacts server.
      Update windows binaries urls
      path syntax tweak.
      Added maintainer mode, updated .gitignore in preparation for adding generated files for distribution.
      Added generated files for 4.8.1 release.
      Adding generated source files for 4.8.1 release.
      Renamed dap4_test thredds test file ins upport of Unidata/netcdf-c#2077
      Additional refactoring of the thredds dap4 test in support of #2077
      Regenerated autoconf scaffolding to incorporate bugfix for #2077
      Update cmake-based builds in support of Unidata/netcdf-c#2077
      Corrected a syntax issue with shell scripts invoked by cmake that could result in a false positive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant