Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zstandard functions do not appear in the documentation (nor do any of the filter functions in dfilter.c) #2333

Closed
edwardhartnett opened this issue May 4, 2022 · 5 comments · Fixed by #2336
Closed

zstandard functions do not appear in the documentation (nor do any of the filter functions in dfilter.c) #2333

edwardhartnett opened this issue May 4, 2022 · 5 comments · Fixed by #2336

Comments

@edwardhartnett
Copy link
Contributor

zstandard functions do not appear in the documentation.

I will submit PR shortly...
@edwardhartnett edwardhartnett changed the title zstandard functions do not appear in the documentation zstandard functions do not appear in the documentation (nor do any of the filter functions in dfilter.c) May 4, 2022
This was referenced May 4, 2022
Closed
Merged
@DennisHeimbigner
Copy link
Collaborator

Please examine PR #2249

@edwardhartnett
Copy link
Contributor Author

@DennisHeimbigner I've looked at #2249 - what am I looking for?

Unless I'm mistaken I don't think it includes the doxygen documentation for the zstandard functions.

@DennisHeimbigner
Copy link
Collaborator

No, but some of the text there might be useful.

@edwardhartnett
Copy link
Contributor Author

It's OK, I've got complete documentation already in the CCR project, I just stole it. ;-)

I added documentation for filter functions that didn't have any.

I have also just added netcdf_filter.h to the doxygen build - previously it was not there.

Once all these PRs are merged I can do another pass to get rid of new doxygen warnings.

@DennisHeimbigner
Copy link
Collaborator

ok, sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@DennisHeimbigner @edwardhartnett