Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all-error-codes.md #2336

Merged
merged 7 commits into from
May 5, 2022
Merged

remove all-error-codes.md #2336

merged 7 commits into from
May 5, 2022

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett edwardhartnett commented May 4, 2022

Fixes #2333.
Part of #2329
Fixes #2186.
Fixes #891

This PR includes PRs #2330 and #2332 and #2384 and should be merged after them (or instead of them).

In this PR I remove all-error-codes.md. These codes are already documented in netcdf.h.

@WardF you probably want to get these documentation fixes in before the 4.9.0 release.

(Also adding netcdf_filter.h to doxygen build.)

@edwardhartnett edwardhartnett requested a review from WardF as a code owner May 4, 2022 16:07
@WardF WardF added this to the 4.9.0 milestone May 4, 2022
@WardF WardF self-assigned this May 4, 2022
@edwardhartnett
Copy link
Contributor Author

I will take down the pre-cursor PRs, since this PR contains all my documentation changes for 4.9.0...

@WardF WardF merged commit c147bdd into Unidata:main May 5, 2022
@edwardhartnett edwardhartnett deleted the ejh_doc_4 branch June 12, 2022 17:12
@WardF
Copy link
Member

WardF commented Aug 19, 2022

We've received a lot of questions in the wake of the v4.9.0 release along the lines of 'where did the error code table go'. While they are indeed documented in netcdf.h, they are not presented in the end-user easy-to-read table format they were previously, so I'll be reversing that part of this change (after ensuring it's at parity with the current state of things).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants