Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLUGIN_INSTALL_DIR issues #2429

Closed
sebastic opened this issue Jun 25, 2022 · 3 comments
Closed

PLUGIN_INSTALL_DIR issues #2429

sebastic opened this issue Jun 25, 2022 · 3 comments

Comments

@sebastic
Copy link
Contributor

netcdf4-python test failures revealed some issues with the CMake build.

The default value doesn't match the documentation:

# If user wants, then install selected plugins (default on)
SET(PLUGIN_INSTALL_DIR "NO" CACHE STRING "Whether and where we should install plugins; defaults to yes")

It suggest being a boolean (for which YES/ON is equivalent), but treating it as such, by using -DPLUGIN_INSTALL_DIR:BOOL=ON, causes the build to fail:

Defaulting to -DPLUGIN_INSTALL_DIR=NOTFOUND

The default path (/usr/local/hdf5/lib/plugin) is also incorrect when using -DCMAKE_INSTALL_PREFIX=/usr and -DCMAKE_INSTALL_LIBDIR=lib/x86_64-linux-gnu. A better default would be ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/hdf5/plugin.
@DennisHeimbigner
Copy link
Collaborator

Odd. I must be testing for the exact value "YES" instead of doing a boolean test.
I will check.

DennisHeimbigner added a commit to DennisHeimbigner/netcdf-c that referenced this issue Jun 25, 2022
@DennisHeimbigner
Fix way CMake handle -DPLUGIN_INSTALL_DIR
c633de1 
re: Issue Unidata#2429

The CMake tests for -DPLUGIN_INSTALL_DIR only accepted
"on" or "off" as boolean values. So extend to accept e.g.
-DPLUGIN_INSTALL_DIR=yes or -DPLUGIN_INSTALL_DIR=1, etc.
@DennisHeimbigner DennisHeimbigner mentioned this issue Jun 25, 2022
Merged
@DennisHeimbigner
Copy link
Collaborator

I hope #2430 fixes this.

@sebastic sebastic mentioned this issue Jun 26, 2022
Closed
@edwardhartnett
Copy link
Contributor

This is fixed now and this issue should be closed.

@WardF WardF closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DennisHeimbigner @WardF @sebastic @edwardhartnett