Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compress http requests #2622

Open
DennisHeimbigner opened this issue Feb 15, 2023 · 1 comment
Open

Compress http requests #2622

DennisHeimbigner opened this issue Feb 15, 2023 · 1 comment

Comments

@DennisHeimbigner
Copy link
Collaborator

Nathan Potter reports that it appears that the netcdf-c http requests
are not using compression. Check and fix.
@DennisHeimbigner
Copy link
Collaborator Author

Turns out there was code for this, but it was using CURLOPT_ENCODING rather
than CURLOPT_ACCEPT_ENCODING. Probably a typo on my part.

DennisHeimbigner added a commit to DennisHeimbigner/netcdf-c that referenced this issue Feb 17, 2023
@DennisHeimbigner
Enable ACCEPT_ENCODING on DAP requests
e31ce10 
re: PR Unidata#2622

H/T Nathan Potter for finding this.

Apparently the existing library DAP code for supporting
compressed http responses was disabled.

So:
1. enable CURLOPT_ACCEPT_ENCODING by default
2. Add a new HTTP.ENCODE for .dodsrc to allow it to be disabled.
@DennisHeimbigner DennisHeimbigner mentioned this issue Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DennisHeimbigner