-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nc_test fail in 4.5.0 with CMake #500
Comments
Sorry for entering too fast, edited. Likely related to the warning in #501. |
Interesting; what platform are you on? I'm unable to recreate this but will keep trying. |
Specifically, which distribution of 64-bit linux, sorry :) |
ArchLinux as usual, sorry to have not mentioned it. I’ll add the log requested by @DennisHeimbigner shortly. |
Relevant section starts at https://paste.xinu.at/xrLi/#n2211 |
This also fails for me:
With gcc 7.2, zlib 1.2.11, szip 2.1.1, hdf5 1.8.18. Debian (latest). And I am not using CMake. |
I can confirm that the test passes if the netcdf-c library is build with debugging flags (all dependent libraries compiled with high optimization). |
I agree, they are pretty aggressive, but hdf5 etc. completes tests without problems. |
The |
I can confirm that a debug build with |
I can confirm that if I only change |
You might be able to get some additional information as follows:
|
Here it is:
|
@DennisHeimbigner Mine is attached here: #500 (comment) |
@ArchangeGabriel when I try that link I get an error message that there is no such file. |
Hum indeed. Maybe the file expired, though that’s not normal. Re-uploaded here: https://gist.github.com/ArchangeGabriel/a5d0abb6363b31f71ce4ad44736c60da |
Looking at the log, it appears the problem is in nc_put_att and nc_rename att. |
With some of the recent memory issues being addressed via PR's, does this issue persist? I'm unable to recreate it on my end. |
@ArchangeGabriel I have looked at your logs. @WardF was there some change merged recently relating to the unsigned/sign char issues somewhere? Also, @ArchangeGabriel, can you try:
The challenge with nc_test is that it's a heck of a program to debug. If we can find a simpler test that is failing, that could make it a lot easier to find the problem. Also have you tried this with the autotools build? |
I’m currently building from git, with both autotools and CMake, I’ll keep you updated. |
Still failing with CMake and O3. Confirmed failing on autotools with O3. Unrelated, but I’ve noticed a compilation warning:
One more in
One in a test:
Now running the check in |
One warning in this folder:
|
Thanks for confirming the issue is still there. I’ll take a look shortly or we will see if Ed has an idea/contribution (given the rate of recent contributions!) |
Howdy @ArchangeGabriel! Thanks for the detailed info! ;-) No need to tell us about warnings. There are lots of warnings in the code that are going to go away shortly (when outstanding PRs get merged). But we still won't be warning-free, yet. OK, I see that you say it fails on autotools. Only with -O3? I will try... |
OK, I am reproducing your problems. There are some new warnings, as well as a lot of warnings that are old-frenimies. So I will wait until @WardF merges my outstanding PRs, which clear up a lot of warnings. |
Yes, we already have determined above that -O3 was the culprit. You can try with CMake or autotools, as long as you’re just -O2 you’re fine. But with -O3 both fail. The reason why CMake revealed it is that its |
|
…les. See Unidata/netcdf-c#500 git-svn-id: https://svn.mcs.anl.gov/repos/parallel-netcdf/trunk@3519 c368ceb8-fd28-0410-a457-e46ee1d7cd4a
…les. See Unidata/netcdf-c#500 git-svn-id: https://svn.mcs.anl.gov/repos/parallel-netcdf/trunk@3519 c368ceb8-fd28-0410-a457-e46ee1d7cd4a
A bit late then, but I can confirm that it works with I can retry with just |
It works without -DCMAKE_BUILD_TYPE=Release (i.e. DEBUG build), but not with it.
The text was updated successfully, but these errors were encountered: