adjust tests and utils for split of libsrc4 and libhdf5 #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ossibility of netcdf-4 build without hdf5
|
WRT DAP4, I have been waiting for you to finish the split. |
|
@DennisHeimbigner OK, awesome! ;-) With this PR, the split is complete. Automake conditionals USE_HDF5 and USE_NETCDF4 are available, as are preprocessor defines in config.h. |
|
@WardF can we get this merged soon? It is the last step in separating libsrc4 and libhdf5. Thanks. |
This was referenced Dec 7, 2018
This was referenced Dec 11, 2018
Closed
|
Thanks @WardF ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #856.
Now getting tests and utils to deal with split of libsrc4 and libhdf5.
With --disable-hdf5, libsrc4 still builds, but not libhdf5, h5_test, and nc_test4. Essentially this is the same as --disable-netcdf-4, but it will be possible to build with HDF4 and not HDF5.
Also it seems that DAP4 should work without HDF5. But right now it does not. In builds where --disable-hdf5 is used, I have automatically turned off DAP4. I would like to change that eventually, so the user could build with dap4 but without HDF5. (@DennisHeimbigner that should be possible, correct?)
The problem now is that ncdump is used for the tests, and it is not yet handling enhanced model features in the absence of HDF5. In many cases the pre-processor macro USE_NETCDF4 needs to be changed to USE_HDF5 in the ncdump code.
This PR is in the queue behind #1231 and includes that PR as well.